Dan Carpenter
2020-Jun-02 10:29 UTC
[Nouveau] [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
The original patch was basically fine. Just add a Fixes tag and resend. regards, dan carpenter
Markus Elfring
2020-Jun-02 11:10 UTC
[Nouveau] [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
> The original patch was basically fine.I propose to reconsider the interpretation of the software situation once more. * Should the allocated clock object be kept usable even after a successful return from this function? * How much do ?destructor? calls matter here for (sub)devices?> Just add a Fixes tag and resend.This tag can help also. Regards, Markus
Dan Carpenter
2020-Jun-02 15:39 UTC
[Nouveau] [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
On Tue, Jun 02, 2020 at 01:10:34PM +0200, Markus Elfring wrote:> > The original patch was basically fine. > > I propose to reconsider the interpretation of the software situation once more. > > * Should the allocated clock object be kept usable even after > a successful return from this function?Heh. You're right. The patch is freeing "clk" on the success path so that doesn't work. regards, dan carpenter
Maybe Matching Threads
- [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
- [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
- [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
- [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()
- [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new