Christoph Böhmwalder
2017-Nov-30 19:53 UTC
[Nouveau] [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings
The kbuild test bot complained about a new coccinelle warning nearby, which sparked a discussion about the assignment to 'memory' inside of the conditional expression. See Link below for the original post. Fix the assignment to silence the coccinelle warning and also make the code look a little nicer. Link: https://lists.freedesktop.org/archives/nouveau/2017-November/029242.html Signed-off-by: Christoph Böhmwalder <christoph at boehmwalder.at> --- drm/nouveau/nvkm/subdev/mmu/uvmm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drm/nouveau/nvkm/subdev/mmu/uvmm.c b/drm/nouveau/nvkm/subdev/mmu/uvmm.c index fa81d0c1..37b201b9 100644 --- a/drm/nouveau/nvkm/subdev/mmu/uvmm.c +++ b/drm/nouveau/nvkm/subdev/mmu/uvmm.c @@ -106,7 +106,8 @@ nvkm_uvmm_mthd_map(struct nvkm_uvmm *uvmm, void *argv, u32 argc) } else return ret; - if (IS_ERR((memory = nvkm_umem_search(client, handle)))) { + memory = nvkm_umem_search(client, handle); + if (IS_ERR(memory)) { VMM_DEBUG(vmm, "memory %016llx %ld\n", handle, PTR_ERR(memory)); return PTR_ERR(memory); } -- 2.13.6
Karol Herbst
2017-Dec-06 10:02 UTC
[Nouveau] [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings
Reviewed-by: Karol Herbst <kherbst at redhat.com> On Thu, Nov 30, 2017 at 8:53 PM, Christoph Böhmwalder <christoph at boehmwalder.at> wrote:> The kbuild test bot complained about a new coccinelle warning nearby, > which sparked a discussion about the assignment to 'memory' inside of > the conditional expression. See Link below for the original post. > > Fix the assignment to silence the coccinelle warning and also make the > code look a little nicer. > > Link: https://lists.freedesktop.org/archives/nouveau/2017-November/029242.html > Signed-off-by: Christoph Böhmwalder <christoph at boehmwalder.at> > --- > drm/nouveau/nvkm/subdev/mmu/uvmm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drm/nouveau/nvkm/subdev/mmu/uvmm.c b/drm/nouveau/nvkm/subdev/mmu/uvmm.c > index fa81d0c1..37b201b9 100644 > --- a/drm/nouveau/nvkm/subdev/mmu/uvmm.c > +++ b/drm/nouveau/nvkm/subdev/mmu/uvmm.c > @@ -106,7 +106,8 @@ nvkm_uvmm_mthd_map(struct nvkm_uvmm *uvmm, void *argv, u32 argc) > } else > return ret; > > - if (IS_ERR((memory = nvkm_umem_search(client, handle)))) { > + memory = nvkm_umem_search(client, handle); > + if (IS_ERR(memory)) { > VMM_DEBUG(vmm, "memory %016llx %ld\n", handle, PTR_ERR(memory)); > return PTR_ERR(memory); > } > -- > 2.13.6 > > _______________________________________________ > Nouveau mailing list > Nouveau at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau
Seemingly Similar Threads
- [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings (fwd)
- [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings (fwd)
- [PATCH drm-misc-next v9 09/12] drm/gpuvm: reference count drm_gpuvm structures
- State of Video Decoding for Maxwell cards
- [RFC PATCH 00/13] SVM (share virtual memory) with HMM in nouveau