Alastair Bridgewater
2017-Jan-11 20:47 UTC
[Nouveau] [PATCH] drm/nouveau: Fix HDA ELD handling (thus, HDMI audio) on gt215
Store the ELD correctly, not just enough copies of the first byte to pad out the given ELD size. Signed-off-by: Alastair Bridgewater <alastair.bridgewater at gmail.com> --- drivers/gpu/drm/nouveau/nvkm/engine/disp/hdagt215.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/hdagt215.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/hdagt215.c index 6f0436d..f8f2f16 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/hdagt215.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/hdagt215.c @@ -59,7 +59,7 @@ gt215_hda_eld(NV50_DISP_MTHD_V1) ); } for (i = 0; i < size; i++) - nvkm_wr32(device, 0x61c440 + soff, (i << 8) | args->v0.data[0]); + nvkm_wr32(device, 0x61c440 + soff, (i << 8) | args->v0.data[i]); for (; i < 0x60; i++) nvkm_wr32(device, 0x61c440 + soff, (i << 8)); nvkm_mask(device, 0x61c448 + soff, 0x80000003, 0x80000003); -- 2.10.2
Ilia Mirkin
2017-Jan-11 20:56 UTC
[Nouveau] [PATCH] drm/nouveau: Fix HDA ELD handling (thus, HDMI audio) on gt215
On Wed, Jan 11, 2017 at 3:47 PM, Alastair Bridgewater <alastair.bridgewater at gmail.com> wrote:> Store the ELD correctly, not just enough copies of the first byte > to pad out the given ELD size. > > Signed-off-by: Alastair Bridgewater <alastair.bridgewater at gmail.com>Great find! Here are some more tags: Fixes: 120b0c39c756 ("drm/nv50-/disp: audit and version SOR_HDA_ELD method") Cc: stable at vger.kernel.org # v3.17+ Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>> --- > drivers/gpu/drm/nouveau/nvkm/engine/disp/hdagt215.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/hdagt215.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/hdagt215.c > index 6f0436d..f8f2f16 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/hdagt215.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/hdagt215.c > @@ -59,7 +59,7 @@ gt215_hda_eld(NV50_DISP_MTHD_V1) > ); > } > for (i = 0; i < size; i++) > - nvkm_wr32(device, 0x61c440 + soff, (i << 8) | args->v0.data[0]); > + nvkm_wr32(device, 0x61c440 + soff, (i << 8) | args->v0.data[i]); > for (; i < 0x60; i++) > nvkm_wr32(device, 0x61c440 + soff, (i << 8)); > nvkm_mask(device, 0x61c448 + soff, 0x80000003, 0x80000003); > -- > 2.10.2 > > _______________________________________________ > Nouveau mailing list > Nouveau at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau