Nouveau - Jul 2015 - [Bug 91231] New: [NV92] Psychonauts (native) segfaults on start when DRI3 enabled

https://bugs.freedesktop.org/show_bug.cgi?id=91231

            Bug ID: 91231
           Summary: [NV92] Psychonauts (native) segfaults on start when
                    DRI3 enabled
           Product: xorg
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Keywords: bisected, regression
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: gyebro69 at gmail.com
        QA Contact: xorg-team at lists.x.org

Created attachment 116944
  --> https://bugs.freedesktop.org/attachment.cgi?id=116944&action=edit
trace generated by apitrace

The game runs natively on Linux. When Mesa was compiled with DRI3 support the
game segfaults when starting and I get this in the terminal:
Psychonauts: nv50/nv50_miptree.c:132: nv50_mt_choose_storage_type: Assertion
`ms == 0' failed.
The game starts properly if I disable DRI3 at runtime (LIBGL_DRI3_DISABLE=1)

The problem is present since

commit 241e7289f25a342a457952b9b0e539c2f0b81d99
Author: Maarten Lankhorst <maarten.lankhorst at ubuntu.com>
Date:   Wed Oct 22 11:04:16 2014 +0200

    enable dri3 support without glamor

When replaying the trace with glretrace the message about the assertion is not
present, but glretrace segfaults with signal 11.

Fedora 22 32-bit
xorg-x11-server-Xorg-1.17.2-1.fc22.i686
Kernel 4.0.6-300.fc22.i686+PAE
VGA compatible controller: NVIDIA Corporation G92 [GeForce GTS 250] (rev a2)
(prog-if 00 [VGA controller])
libdrm-2.4.62-1-g676c806
xf86-video-nouveau-1.0.11-23-gdfd827c
Mesa 10.6-branchpoint-826-gff0a41b

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150705/dd5b22ef/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91231

--- Comment #1 from Béla Gyebrószki <gyebro69 at gmail.com> ---
Created attachment 116945
  --> https://bugs.freedesktop.org/attachment.cgi?id=116945&action=edit
XOrg.log

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150705/dcbc333c/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91231

--- Comment #2 from Ilia Mirkin <imirkin at alum.mit.edu> ---
The assertion is regarding PIPE_BIND_SCANOUT + nr_samples != 0. I suspect this
might be a dri st bug which only surfaces with the new mechanisms that dri3
enables.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150705/c5105525/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91231

--- Comment #3 from Béla Gyebrószki <gyebro69 at gmail.com> ---
Created attachment 116946
  --> https://bugs.freedesktop.org/attachment.cgi?id=116946&action=edit
backtrace from the game and glretrace

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150705/ec091535/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91231

--- Comment #4 from Béla Gyebrószki <gyebro69 at gmail.com> ---
If you have a Steam account and Steam for Linux installed you can reproduce the
segfault with these native Linux demos on Steam:
- 'Running with Rifles' demo (note: I had to remove libstdc++.so.6 and
libxcb.so.1 from ./lib).
- Torchlight II demo (the game starts with default settings, you need to enable
anti-aliasing in-game option and restart the game to reproduce this bug).

All those games crash on start with
>nv50/nv50_miptree.c:132: nv50_mt_choose_storage_type: Assertion `ms ==
0' failed.
when DRI3 is enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150706/15cbb3d6/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91231

--- Comment #5 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Marek posted a patch for this at http://patchwork.freedesktop.org/patch/53843/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150707/ad8a33bb/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91231

Béla Gyebrószki <gyebro69 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyebro69 at gmail.com

--- Comment #6 from Béla Gyebrószki <gyebro69 at gmail.com> ---
(In reply to Ilia Mirkin from comment #5)
> Marek posted a patch for this at
> http://patchwork.freedesktop.org/patch/53843/
The patch works and fixes the problem in all the affected games that I know of.
Thank you both for your help fixing this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150707/05759baa/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91231

Béla Gyebrószki <gyebro69 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Béla Gyebrószki <gyebro69 at gmail.com> ---
Patch committed, marking the bug as fixed.
http://cgit.freedesktop.org/mesa/mesa/commit/?id=6611f65047575054a38ce83ebfe0331e39e1774f

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150708/4c009003/attachment.html>