Nouveau - May 2015 - [Bug 90350] New: [G96] Portal's portal are incorrectly rendered

https://bugs.freedesktop.org/show_bug.cgi?id=90350

            Bug ID: 90350
           Summary: [G96] Portal's portal are incorrectly rendered
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: pierre.morrow at free.fr
        QA Contact: nouveau at lists.freedesktop.org

Portal's portals are filled with some matter when running the game on my
G96.
Running on my MCP79 is fine.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150506/0b4e6ee9/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=90350

--- Comment #1 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Trace available at:

http://people.freedesktop.org/~imirkin/traces/portal_bug_portalrendering_G96.trace.xz

Verified to render correctly on i965 haswell. Would be nice if someone else
with a G96 or older card can verify it also renders wrong. Otherwise it's an
issue on the macbook gpu setup.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150506/dc871783/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=90350

--- Comment #2 from Pierre Moreau <pierre.morrow at free.fr> ---
Bisected to

commit 44673512a84c0897c8eddabf4a56e79b7d5b3395
Author: Roy Spliet <rspliet at eclipso.eu>
Date:   Mon Jan 5 00:22:17 2015 +0100

    nv50/ir: Add sat modifier for mul

    Signed-off-by: Roy Spliet <rspliet at eclipso.eu>
    Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150507/f9686f67/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=90350

--- Comment #3 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Created attachment 115652
  --> https://bugs.freedesktop.org/attachment.cgi?id=115652&action=edit
saturate shader test

On each of your NV96 and NVAC, please run the attached test through
shader_runner. Also remove the "+ arg2" from the result computation
and run it
again. I suspect that only NV96 + arg2 removed will fail.

[The results that *actually* test clamping are 16, 20, 28, and 36.]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150509/d47120e7/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=90350

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Looks like I was right in my guess. Since NVAC tends to have the same things as
NVA0, I'm assuming that FMUL.SAT becomes a thing on G200+. Fix pushed:

commit da136dc07ddb6147d181c96f475b94f6281efd73
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Sat May 9 03:26:07 2015 -0400

    nv50/ir: only enable mul saturate on G200+

    Commit 44673512a84 enabled support for saturating fmul. However
    experimentally this does not seem to work on the older chips. Restrict
    the feature to G200 (NVA0) and later.

    Reported-by: Pierre Moreau <pierre.morrow at free.fr>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90350
    Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
    Tested-by: Pierre Moreau <pierre.morrow at free.fr>
    Reviewed-by: Tobias Klausmann <tobias.johannes.klausmann at
mni.thm.de>
    Cc: mesa-stable at lists.freedesktop.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150509/1a4d89c4/attachment.html>