Nouveau - Jan 2011 - [Bug 33434] New: [nouveau nv84] BUG while reloading module

https://bugs.freedesktop.org/show_bug.cgi?id=33434

           Summary: [nouveau nv84] BUG while reloading module
           Product: xorg
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau at lists.freedesktop.org
        ReportedBy: shiningxc at gmail.com
         QAContact: xorg-team at lists.x.org


BUG: unable to handle kernel paging request at ffffffffa024dd8f

git as of today:
kernel: 64b792
drm: 550fe2
ddx: 38e880

01:00.0 VGA compatible controller: nVidia Corporation G84 [GeForce 8600M GT]
(rev a1)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=33434

--- Comment #1 from Xavier <shiningxc at gmail.com> 2011-01-24 14:15:49
PST ---
Created an attachment (id=42411)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42411)
dmesg

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=33434

--- Comment #2 from Ben Skeggs <skeggsb at gmail.com> 2011-01-24 14:58:38
PST ---
Yeah I've seen this too, very annoying.  I don't believe it was anything
in
nouveau directly that causes it.  Any chance you could bisect it back to find
the offending commit?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=33434

--- Comment #3 from Xavier <shiningxc at gmail.com> 2011-01-29 14:31:11
PST ---
looks like thats the culprit :

commit 3d58ec154bc87b206a3439f064e1c8aa6090c1ee
Author: Lucas Stach <dev at lynxeye.de>
Date:   Thu Jan 6 20:29:53 2011 +0100

    drm/nouveau: fix hwmon device binding

    Bind the hwmon structs to nouveau device kobj. This makes sure
    the hwmon files are created in the device subdir in line with
    all other hwmon drivers.

    Signed-off-by: Lucas Stach <dev at lynxeye.de>
    Signed-off-by: Ben Skeggs <bskeggs at redhat.com>

diff --git a/drivers/gpu/drm/nouveau/nouveau_pm.c
b/drivers/gpu/drm/nouveau/nouveau_pm.c
index d938141..fb846a3 100644
--- a/drivers/gpu/drm/nouveau/nouveau_pm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_pm.c
@@ -422,8 +422,7 @@ nouveau_hwmon_init(struct drm_device *dev)
                return ret;
        }
        dev_set_drvdata(hwmon_dev, dev);
-       ret = sysfs_create_group(&hwmon_dev->kobj,
-                                       &hwmon_attrgroup);
+       ret = sysfs_create_group(&dev->pdev->dev.kobj,
&hwmon_attrgroup);
        if (ret) {
                NV_ERROR(dev,
                        "Unable to create hwmon sysfs file: %d\n",
ret);

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=33434

--- Comment #4 from Lucas Stach <dev at lynxeye.de> 2011-01-30 00:26:22
PST ---
Oh. This seems my fault. I have not tested with reloading, sorry.

I will look into this today and try to fix it without the need to revert this
commit.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=33434

--- Comment #5 from Lucas Stach <dev at lynxeye.de> 2011-01-30 02:12:26
PST ---
Patch is on the mailing list.
Again sorry for your inconvenience and thanks for your time bisecting this.

I will leave this bug open till the fix is in master.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=33434

--- Comment #6 from Xavier <shiningxc at gmail.com> 2011-01-30 03:10:24
PST ---
I wake up and get the same fix from 2 different persons :)
joi on IRC 12h ago :
00:39   joi >> shining^: http://paste.pocoo.org/show/328947/ <- should
fix it

I just applied and it does work, so thank you both.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=33434

Ben Skeggs <skeggsb at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Ben Skeggs <skeggsb at gmail.com> 2011-01-30 14:27:54
PST ---
Fixed in nouveau master.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.