netfilter buglog - Apr 2023 - [Bug 1670] New: json schema does not support comments on tables

https://bugzilla.netfilter.org/show_bug.cgi?id=1670

            Bug ID: 1670
           Summary: json schema does not support comments on tables
           Product: nftables
           Version: 1.0.x
          Hardware: x86_64
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: nft
          Assignee: pablo at netfilter.org
          Reporter: danw at redhat.com

If you add a table with a comment, the comment shows up in "nft list"
but not
in "nft -j list":

$ nft add table inet test3 '{comment "this is a comment";}'
$ nft list table inet test3
table inet test3 {
    comment "this is a comment"
}
$ nft -j list table inet test3
{"nftables": [{"metainfo": {"version":
"1.0.1", "release_name": "Fearless
Fosdick #3", "json_schema_version": 1}}, {"table":
{"family": "inet", "name":
"test3", "handle": 5}}]}
$

If you try to add a table with a comment via json, the comment is ignored:

$ nft -j -f -
{ "nftables": [ { "add": { "table": {
"family": "inet", "name": "test4",
"comment": "comment4" } } } ] }
^D
$ nft list table inet test4
table inet test4 {
}
$

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20230406/b593c1a2/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1670

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Pablo Neira Ayuso <pablo at netfilter.org> ---
https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230424212145.213584-1-pablo
at netfilter.org/

Thanks for reporting.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20230424/a93a5943/attachment-0001.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1670

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Pablo Neira Ayuso <pablo at netfilter.org> ---
Upstream fixes:

bd976ab13b4d ("json: allow to specify comment on chain")
fd595286a68e ("json: allow to specify comment on table")

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20230425/dcae2d3e/attachment.html>