netfilter buglog - Oct 2019 - [Bug 1369] New: ipset save|list -sorted sorts alphabetically instead of naturally

https://bugzilla.netfilter.org/show_bug.cgi?id=1369

            Bug ID: 1369
           Summary: ipset save|list -sorted sorts alphabetically instead
                    of naturally
           Product: ipset
           Version: unspecified
          Hardware: x86_64
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: default
          Assignee: netfilter-buglog at lists.netfilter.org
          Reporter: dominik at greysector.net

Description of problem:
ipset save|list -sorted sorts IP (network) addresses as if they were text
instead of naturally as IP addresses, i.e. 95.0.0.0 should be sorted before
107.0.0.0.

Version-Release number of selected component (if applicable):
ipset-7.2

How reproducible:
Always

Steps to Reproduce:
1. ipset create foo hash:net
2. ipset add foo 95.0.0.0/8
3. ipset add foo 107.0.0.0/8
4. ipset save foo -sorted

Actual results:
create foo hash:net family inet hashsize 1024 maxelem 65536
add foo 107.0.0.0/8
add foo 95.0.0.0/8

Expected results:
create foo hash:net family inet hashsize 1024 maxelem 65536
add foo 95.0.0.0/8
add foo 107.0.0.0/8

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20191008/99ee7038/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1369

Jozsef Kadlecsik <kadlec at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kadlec at netfilter.org
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Jozsef Kadlecsik <kadlec at netfilter.org> ---
Yes, the sorting happened textually. I added more code to handle the natural
listing of IP addresses, including the case of subnets where most specific
sorted first.

Thanks for the reporting.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20191031/573ee782/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1369

--- Comment #2 from dominik at greysector.net ---
(In reply to Jozsef Kadlecsik from comment #1)
> Yes, the sorting happened textually. I added more code to handle the
natural
> listing of IP addresses, including the case of subnets where most specific
> sorted first.
> 
> Thanks for the reporting.
That's excellent, thank you for such quick reaction.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20191031/906d9193/attachment.html>