netfilter buglog - Jul 2019 - [Bug 1354] New: cat foo.nft | nft -f - produces syntax error not seen with nft -f foo.nft

https://bugzilla.netfilter.org/show_bug.cgi?id=1354

            Bug ID: 1354
           Summary: cat foo.nft | nft -f - produces syntax error not seen
                    with nft -f foo.nft
           Product: nftables
           Version: unspecified
          Hardware: x86_64
                OS: Debian GNU/Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: nft
          Assignee: pablo at netfilter.org
          Reporter: jonas at zombofant.net

Created attachment 565
  --> https://bugzilla.netfilter.org/attachment.cgi?id=565&action=edit
File reproducing the issue

root is not needed to reproduce this.

How to reproduce:

1. Download the attached file
2. Execute cat foo.nft | nft -f -
3. Execute nft -f foo.nft

I expect both commands to behave exactly the same, given that the inputs are
exactly the same (just delivered through a different mechanism).

However, cat foo.nft | nft -f - produces an error message:

/dev/stdin:819:5-10: Error: syntax error, unexpected string

nft -f foo.nft works.

I dug further into this with other examples, and it looks to me as if -f - eats
single bytes from the input before they reach the parser. I don't have an
example at hand which reproduces this though.

(The example file is obviously contrived to reproduce the bug.)

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20190721/8a87612b/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1354

--- Comment #1 from Jonas Sch�fer <jonas at zombofant.net> ---
Note, this is with nft v0.9.0, I was unable to build nft v0.9.1 or master on my
machine within reasonable time due to dependencies. Sorry if this bug is fixed
in v0.9.1+; I was unable to find anything related to this in the bugzilla.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20190721/37aeabb0/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1354

Florian Westphal <fw at strlen.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fw at strlen.de
             Status|NEW                         |ASSIGNED
           Assignee|pablo at netfilter.org         |fw at strlen.de

--- Comment #2 from Florian Westphal <fw at strlen.de> ---
(In reply to Jonas Sch�fer from comment #1)
> Note, this is with nft v0.9.0, I was unable to build nft v0.9.1 or master
on
> my machine within reasonable time due to dependencies. Sorry if this bug is
> fixed in v0.9.1+; I was unable to find anything related to this in the
> bugzilla.
Its not fixed.  This is caused by the scanner -- it relies on fseek() to
re-position the input stream, but that only works for files.
I'll send a patch to switch to fgetc().

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20190721/1e64f60e/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1354

Florian Westphal <fw at strlen.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tad.ashlock at gmail.com

--- Comment #3 from Florian Westphal <fw at strlen.de> ---
*** Bug 1355 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20190721/fdc7faad/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1354

--- Comment #4 from Tad Ashlock <tad.ashlock at gmail.com> ---
The patch resolves the problem I had been encountering.  Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20190724/1c102de7/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1354

Florian Westphal <fw at strlen.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Florian Westphal <fw at strlen.de> ---
http://git.netfilter.org/nftables/commit/?id=423abaa40ec47204a08b2e4d3383b7b74acd1d0a

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20190730/3bd6ebce/attachment.html>