netfilter buglog - Jun 2019 - [Bug 1341] New: Usage message does not mention [file] argument

https://bugzilla.netfilter.org/show_bug.cgi?id=1341

            Bug ID: 1341
           Summary: Usage message does not mention [file] argument
           Product: iptables
           Version: CVS (please indicate timestamp)
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: iptables-restore
          Assignee: netfilter-buglog at lists.netfilter.org
          Reporter: matt at meinwald.name

The optional [file] argument is documented in the manpage, but is not present
in the usage message as of the latest commit I see
(093cec72e7f7793d55fa1547cadb6655104feb5e).

It looks like this feature has been available for quite some time, but was only
added to the manpage in 2015. I propose the following trivial update to bring
the usage message in sync as well:

diff --git a/iptables/xtables-restore.c b/iptables/xtables-restore.c
index 86f6a3a..13b9320 100644
--- a/iptables/xtables-restore.c
+++ b/iptables/xtables-restore.c
@@ -43,7 +43,7 @@ static const struct option options[] = {

 static void print_usage(const char *name, const char *version)
 {
-    fprintf(stderr, "Usage: %s [-c] [-v] [-V] [-t] [-h] [-n] [-T table]
[-M
command] [-4] [-6]\n"
+    fprintf(stderr, "Usage: %s [-c] [-v] [-V] [-t] [-h] [-n] [-T table]
[-M
command] [-4] [-6] [file]\n"
             "       [ --counters ]\n"
             "       [ --verbose ]\n"
             "       [ --version]\n"

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20190607/f05580ae/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1341

Florian Westphal <fw at strlen.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fw at strlen.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Florian Westphal <fw at strlen.de> ---
patched in iptables.git master now, will be in 1.8.4 release.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20190916/df9d38de/attachment.html>