netfilter buglog - Jul 2017 - [Bug 1163] New: include the missing header and use more portable types

https://bugzilla.netfilter.org/show_bug.cgi?id=1163

            Bug ID: 1163
           Summary: include the missing header and use more portable types
           Product: libnfnetlink
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: libnfnetlink
          Assignee: netfilter-buglog at lists.netfilter.org
          Reporter: xw897002528 at gmail.com

i need to use the following scripts to fix the build with musl:

sed -e "/#include <linux\/netlink.h>/i #include
<stdint.h>" \
        -i include/libnfnetlink/libnfnetlink.h
find . -type f -exec sed -e "s;u_int;uint;g" -i "{}" \;

Header files provided by musl are very clear and strict, so

1. The first command means libnfnetlink depends on an indirect way to include
stdint.h, maybe one of the glibc-header. It's not portable.

2. The second command means you use a type specified by gnu or bsd, though
it's
defined at sys/types.h in musl, too, but you did not include the file directly.
My suggestion is to use unsigned int instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20170722/e214fba6/attachment.html>