netfilter buglog - Jan 2017 - [Bug 1110] New: Build failure if --with-xtables

https://bugzilla.netfilter.org/show_bug.cgi?id=1110

            Bug ID: 1110
           Summary: Build failure if --with-xtables
           Product: nftables
           Version: unspecified
          Hardware: x86_64
                OS: other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: iptables over nftable
          Assignee: pablo at netfilter.org
          Reporter: robby at rlworkman.net

On Slackware -current (post 14.2) with iptables-1.6.0, libmnl-1.0.3,
libnftnl-1.0.7, and nftables-0.7, this fails to build:

make  all-recursive
make[1]: Entering directory '/root/tmp/nftables-0.7'
Making all in src
make[2]: Entering directory '/root/tmp/nftables-0.7/src'
make  all-am
make[3]: Entering directory '/root/tmp/nftables-0.7/src'
  CC       xt.o
xt.c: In function ‘xt_stmt_xlate’:
xt.c:31:24: warning: implicit declaration of function ‘xt_xlate_alloc’
[-Wimplicit-function-declaration]
  struct xt_xlate *xl = xt_xlate_alloc(10240);
                        ^
xt.c:31:24: warning: initialization makes pointer from integer without a cast
[-Wint-conversion]
xt.c:37:28: error: ‘struct xtables_match’ has no member named ‘xlate’
   } else if (stmt->xt.match->xlate) {
                            ^
xt.c:38:11: error: variable ‘params’ has initializer but incomplete type
    struct xt_xlate_mt_params params = {
           ^
xt.c:39:5: error: unknown field ‘ip’ specified in initializer
     .ip  = stmt->xt.entry,
     ^
xt.c:39:12: warning: excess elements in struct initializer
     .ip  = stmt->xt.entry,
            ^
xt.c:39:12: note: (near initialization for ‘params’)
xt.c:40:5: error: unknown field ‘match’ specified in initializer
     .match  = stmt->xt.match->m,
     ^
xt.c:40:15: warning: excess elements in struct initializer
     .match  = stmt->xt.match->m,
               ^
xt.c:40:15: note: (near initialization for ‘params’)
xt.c:41:5: error: unknown field ‘numeric’ specified in initializer
     .numeric        = 0,
     ^
xt.c:41:23: warning: excess elements in struct initializer
     .numeric        = 0,
                       ^
xt.c:41:23: note: (near initialization for ‘params’)
xt.c:38:30: error: storage size of ‘params’ isn’t known
    struct xt_xlate_mt_params params = {
                              ^
xt.c:44:18: error: ‘struct xtables_match’ has no member named ‘xlate’
    stmt->xt.match->xlate(xl, &params);
                  ^
xt.c:45:17: warning: implicit declaration of function ‘xt_xlate_get’
[-Wimplicit-function-declaration]
    printf("%s", xt_xlate_get(xl));
                 ^
xt.c:45:11: warning: format ‘%s’ expects argument of type ‘char *’, but
argument 2 has type ‘int’ [-Wformat=]
    printf("%s", xt_xlate_get(xl));
           ^
xt.c:38:30: warning: unused variable ‘params’ [-Wunused-variable]
    struct xt_xlate_mt_params params = {
                              ^
xt.c:56:29: error: ‘struct xtables_target’ has no member named ‘xlate’
   } else if (stmt->xt.target->xlate) {
                             ^
xt.c:57:11: error: variable ‘params’ has initializer but incomplete type
    struct xt_xlate_tg_params params = {
           ^
xt.c:58:5: error: unknown field ‘ip’ specified in initializer
     .ip  = stmt->xt.entry,
     ^
xt.c:58:12: warning: excess elements in struct initializer
     .ip  = stmt->xt.entry,
            ^
xt.c:58:12: note: (near initialization for ‘params’)
xt.c:59:5: error: unknown field ‘target’ specified in initializer
     .target  = stmt->xt.target->t,
     ^
xt.c:59:16: warning: excess elements in struct initializer
     .target  = stmt->xt.target->t,
                ^
xt.c:59:16: note: (near initialization for ‘params’)
xt.c:60:5: error: unknown field ‘numeric’ specified in initializer
     .numeric        = 0,
     ^
xt.c:60:23: warning: excess elements in struct initializer
     .numeric        = 0,
                       ^
xt.c:60:23: note: (near initialization for ‘params’)
xt.c:57:30: error: storage size of ‘params’ isn’t known
    struct xt_xlate_tg_params params = {
                              ^
xt.c:63:19: error: ‘struct xtables_target’ has no member named ‘xlate’
    stmt->xt.target->xlate(xl, &params);
                   ^
xt.c:64:11: warning: format ‘%s’ expects argument of type ‘char *’, but
argument 2 has type ‘int’ [-Wformat=]
    printf("%s", xt_xlate_get(xl));
           ^
xt.c:57:30: warning: unused variable ‘params’ [-Wunused-variable]
    struct xt_xlate_tg_params params = {
                              ^
xt.c:74:2: warning: implicit declaration of function ‘xt_xlate_free’
[-Wimplicit-function-declaration]
  xt_xlate_free(xl);
  ^
make[3]: *** [Makefile:455: xt.o] Error 1
make[3]: Leaving directory '/root/tmp/nftables-0.7/src'
make[2]: *** [Makefile:332: all] Error 2
make[2]: Leaving directory '/root/tmp/nftables-0.7/src'
make[1]: *** [Makefile:386: all-recursive] Error 1
make[1]: Leaving directory '/root/tmp/nftables-0.7'
make: *** [Makefile:326: all] Error 2

For the sake of clarity, it builds fine if I --with-xtables is not passed to
configure.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20170103/65f65a65/attachment-0001.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1110

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Pablo Neira Ayuso <pablo at netfilter.org> ---
iptables 1.6.1 release should fix this:

http://www.netfilter.org/projects/iptables/downloads.html#iptables-1.6.1

We should probably check version via pkg-config .pc file from nftables, so
compilation doesn't break hard like this.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20170127/c0cf3ca4/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1110

--- Comment #2 from Robby Workman <robby at rlworkman.net> ---
Confirmed that this is indeed fixed with iptables-1.6.1. Thanks, Pablo!
I'll let you handle closing the bug as desired because I'm not familiar
with
your desired workflow with respect to that.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20170128/14048fdc/attachment-0001.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1110

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20170130/c1eb6ab8/attachment.html>