netfilter buglog - Jan 2014 - [Bug 891] New: Build failure on Slackware AMD 64bit with GLIBC 2.7

https://bugzilla.netfilter.org/show_bug.cgi?id=891

           Summary: Build failure on Slackware AMD 64bit with GLIBC  2.7
           Product: ipset
           Version: unspecified
          Platform: x86_64
        OS/Version: other
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: default
        AssignedTo: netfilter-buglog at lists.netfilter.org
        ReportedBy: nick at linicks.net
   Estimated Hours: 0.0


Being new to ipset, I tried to build from latest source today, and got build
errors:

  CCLD     ipset
../lib/.libs/libipset.a(session.o): In function `rawdata2attr':
/home/nick/targz/ipset-6.20.1/lib/session.c:1495: undefined reference to
`htobe64'
../lib/.libs/libipset.a(session.o): In function `attr2data':
/home/nick/targz/ipset-6.20.1/lib/session.c:618: undefined reference to
`be64toh'
collect2: ld returned 1 exit status

Researching, it turns out I need GLIBC => 2.9 to supply this.

I eventually managed to build ipset (and all works great!) by adding:

#define be64toh(x) (x)
#define htobe64(x) (x)

to lib/sessions.c

Now, I dunno if this is the correct fix or not - or if it doesn't matter on
a
non-portable binary, but why doesn't ./configure pick this up?

Nick

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=891

--- Comment #1 from Nick <nick at linicks.net> 2014-01-30 19:42:30 CET ---
BTW, forgot to say this is with linux-3.13.1

Nick

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=891

Jozsef Kadlecsik <kadlec at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kadlec at netfilter.org

--- Comment #2 from Jozsef Kadlecsik <kadlec at netfilter.org> 2014-09-23
11:48:29 CEST ---
No, that's not correct, but affect only packet and byte counters.

I have committed the fix in the ipset git tree and it'll present in ipset
release 6.23.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=891

Jozsef Kadlecsik <kadlec at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=891

--- Comment #3 from Nick <nick at linicks.net> 2014-09-23 17:44:34 CEST
---
(In reply to comment #2)
> No, that's not correct, but affect only packet and byte counters.
> 
> I have committed the fix in the ipset git tree and it'll present in
ipset
> release 6.23.
Thank you !

Nick

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.