netfilter buglog - Jun 2013 - [Bug 828] New: connlabel.conf is missing in built package if it exists on the system.

https://bugzilla.netfilter.org/show_bug.cgi?id=828

           Summary: connlabel.conf is missing in built package if it
                    exists on the system.
           Product: iptables
           Version: unspecified
          Platform: x86_64
        OS/Version: other
            Status: NEW
          Severity: minor
          Priority: P5
         Component: unknown
        AssignedTo: netfilter-buglog at lists.netfilter.org
        ReportedBy: monster.romster at gmail.com
   Estimated Hours: 0.0


When I build iptables and have DESTDIR set /etc/xtables/connlabel.conf is
always missing from my footprint due to it checking on the system
/etc/xtables/connlabel.conf and not in the DESTDIR path.

Package managers have their own way to deal with merging, replace, or keep
changes to to deal with files in /etc

I beleave this:

 install-data-hook:                                                             
        @mkdir -p -m 755 $(DESTDIR)/etc/xtables/ || :                           
        @test -f /etc/xtables/connlabel.conf || $(INSTALL) -m 644
etc/xtables/connlabel.conf $(DESTDIR)/etc/xtables/connlabel.conf || :  

Should be this

@test -f $(DESTDIR)/etc/xtables/connlabel.conf || $(INSTALL) -m 644
etc/xtables/connlabel.conf $(DESTDIR)/etc/xtables/connlabel.conf || :

pre-pending $(DESTDIR) for the expected behavior.

p.s. on a side note we are at version iptables 1.4.19.1, but this version in
bug tracker does note even go past the 1.3.x branch.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=828

Phil Oester <netfilter at linuxace.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |netfilter at linuxace.com
         Resolution|                            |FIXED

--- Comment #1 from Phil Oester <netfilter at linuxace.com> 2013-06-12
22:06:00 CEST ---
This was fixed via commit c5459339 ("iptables: Fix connlabel.conf install
location").  Closing.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.