netfilter buglog - May 2013 - [Bug 825] New: broken led-delay parameter in the LED extension

https://bugzilla.netfilter.org/show_bug.cgi?id=825

           Summary: broken led-delay parameter in the LED extension
           Product: iptables
           Version: CVS (please indicate timestamp)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: iptables
        AssignedTo: netfilter-buglog at lists.netfilter.org
        ReportedBy: rom251 at yahoo.fr
   Estimated Hours: 0.0


file: extensions/libxt_LED.c [e6cf849764256651c17e9e9e3bb3037318f2b993]
https://git.netfilter.org/iptables/tree/extensions/libxt_LED.c

Hello, while trying to get the LED extension work on my build of OpenWRT I
noticed that whatever parameter of led-delay you are using (other than inf)
ends up with a rule at 0 ms.
This is due to the checked value never assigned to the structure in 
https://git.netfilter.org/iptables/tree/extensions/libxt_LED.c#n63

        else if (!xtables_strtoui(cb->arg, NULL, &delay, 0, UINT32_MAX))
            xtables_error(PARAMETER_PROBLEM,
                "Delay value must be within range 0..%u",
                UINT32_MAX);

led->delay is never assigned with the value given by the user
I changed it to

        else if (!xtables_strtoui(cb->arg, NULL, &led->delay, 0,
UINT32_MAX))
            xtables_error(PARAMETER_PROBLEM,
                "Delay value must be within range 0..%u",
                UINT32_MAX);

and it is now working correctly.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=825

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |pablo at netfilter.org
         Resolution|                            |FIXED

--- Comment #1 from Pablo Neira Ayuso <pablo at netfilter.org> 2013-05-30
12:53:14 CEST ---
Applied this patch to master:

http://git.netfilter.org/iptables/commit/?id=96c42d4c46df3edbd41fa47b860fba217f03cfeb

Thanks.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.