netfilter buglog - Mar 2003 - [Bug 20] problems with static linking of iptables-1.2.7

https://bugzilla.netfilter.org/cgi-bin/bugzilla/show_bug.cgi?id=20





------- Additional Comments From laforge@netfilter.org  2003-03-04 18:46 -------
is this bug (esp. the dscp-issue) still present with current CVS?  I can't
even
reproduce the problem anymore...



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

https://bugzilla.netfilter.org/cgi-bin/bugzilla/show_bug.cgi?id=20





------- Additional Comments From ratz@tac.ch  2003-03-06 11:20 -------
This seems to have been fixed now. I've tested it with
IPTABLES_VERSION="1.2.7a-20030305". It compiled fine, although a few
warnings
showed up. In case you're interested:

--- iptables-1.2.7a-20030305/iptables-restore.c	Mon Mar  3 09:08:37 2003
+++ iptables-1.2.7a-20030305-ratz/iptables-restore.c	Thu Mar  6 11:13:26 2003@@
-155,7 +155,7 @@
 	
 	/* Grab standard input. */
 	while (fgets(buffer, sizeof(buffer), in)) {
-		int ret;
+		int ret = 0;
 
 		line++;
 		if (buffer[0] == '\n') continue;
diff -ur iptables-1.2.7a-20030305/iptables.c
iptables-1.2.7a-20030305-ratz/iptables.c
--- iptables-1.2.7a-20030305/iptables.c	Mon Mar  3 09:08:37 2003
+++ iptables-1.2.7a-20030305-ratz/iptables.c	Thu Mar  6 11:11:06 2003
@@ -336,7 +336,7 @@
 void
 exit_tryhelp(int status)
 {
-	if (line =! -1)
+	if (line != -1)
 		fprintf(stderr, "Error occured at line: %d\n", line);
 	fprintf(stderr, "Try `%s -h' or '%s --help' for more
information.\n",
 			program_name, program_name );



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

https://bugzilla.netfilter.org/cgi-bin/bugzilla/show_bug.cgi?id=20

laforge@netfilter.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From laforge@netfilter.org  2003-03-06 12:55 -------
the second hunk was already in CVS (maybe slightly after the snapshot you were
using was created).  The first hunk is a compiler stupidity.  ret can never be
used uninitialized, since the only case where it is not initialized terminates
unconditionally with 'continue'.

applying it to make gcc happy...

thanks.



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.