Mongrel users - Jul 2006 - s/IF_UNMODIFIED_SINCE/IF_MODIFIED_SINCE/ ???

I''ve noticed in the source code that Mongrel handles the
IF_UNMODIFIED_SINCE header.  I thought this rather odd, since
IF_UNMODIFIED_SINCE is generally only useful with PUT.  Even more odd
is that there is no mention of IF_MODIFIED_SINCE in Mongrel which is
useful with GET (although not as useful as IF_NONE_MATCH of course).

Is this a bug in Mongrel?

-Tim

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Tim,
> I''ve noticed in the source code that Mongrel handles the
> IF_UNMODIFIED_SINCE header.  I thought this rather odd, since
> IF_UNMODIFIED_SINCE is generally only useful with PUT.  Even more odd
> is that there is no mention of IF_MODIFIED_SINCE in Mongrel which is
> useful with GET (although not as useful as IF_NONE_MATCH of course).
>
> Is this a bug in Mongrel?
I wrote some of the code that does this, and I think it might be a
bug.  Good catch.

The test cases passed, and the browser testing I did passed too. The
code was created to function when either, or both is present.  Since
most browsers send an ETag too, it would''ve worked in those cases.

I probably got the header wrong when I wrote the test case, and the
mistake rippled out into the code.

The actual logic should still be correct its just the header name
that is wrong.  I''ll submit a patch to fix this.

- --

Thanks,

Dan
__________________________________________________________________

Dan Kubb
Autopilot Marketing Inc.

Email: dan.kubb at autopilotmarketing.com
Phone: 1 (604) 820-0212
Web:   http://autopilotmarketing.com/
vCard: http://autopilotmarketing.com/~dan.kubb/vcard
__________________________________________________________________



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (Darwin)

iD8DBQFEyrM44DfZD7OEWk0RApV+AJ9e5GdbxDdOrCem1x+fmBhoIHSPMQCdHu8R
ZgyyiAHV3+Bjx5/SDwcVKbo=0oEA
-----END PGP SIGNATURE-----

On Fri, 2006-07-28 at 18:29 -0400, Tim Olsen wrote:
> I''ve noticed in the source code that Mongrel handles the
> IF_UNMODIFIED_SINCE header.  I thought this rather odd, since
> IF_UNMODIFIED_SINCE is generally only useful with PUT.  Even more odd
> is that there is no mention of IF_MODIFIED_SINCE in Mongrel which is
> useful with GET (although not as useful as IF_NONE_MATCH of course).
> 
> Is this a bug in Mongrel?
Alright, I got Dan''s patch in the queue and this will be fixed in the
0.3.13.4 pre-release.


-- 
Zed A. Shaw
http://www.zedshaw.com/
http://mongrel.rubyforge.org/
http://www.railsmachine.com/ -- Need Mongrel support?