Mehdi AMINI via llvm-dev
2021-Oct-19 17:39 UTC
[llvm-dev] Upcoming change with how libc++, libc++abi and libunwind are being built
On Tue, Oct 19, 2021 at 9:37 AM Louis Dionne via llvm-dev < llvm-dev at lists.llvm.org> wrote:> > > On Tue, Oct 19, 2021 at 12:45 AM Michael Kruse <llvmdev at meinersbur.de> > wrote: > >> Am Mo., 18. Okt. 2021 um 15:19 Uhr schrieb Louis Dionne < >> ldionne.2 at gmail.com>: >> > Nowadays, we handle all libc++'s own build bots through BuildKite at >> https://buildkite.com/llvm-project/libcxx-ci. >> >> I didn't know. Good that there is systematic testing, but I am a bit >> concerned about the fracturing of the CI infrastructure (Buildbot, >> Green dragon, GitHub actions, Buildkite, ...) >> > > For libc++/libc++abi/libunwind, it's actually quite simple. There's > exactly one place to look, and it's BuildKite. And it runs systematically > on all changes. >Did you find a solution for having blamelist and blame emails on BuildKite? Improving the Buildkite UI to have a good log scrubbing to the level of what we have with buildbot is doable, but I didn't really see how to fix the above. (I'm doing the opposite move right now: leaving BuildKite for MLIR CI to adopt buildbot).> > - Buildbot: I removed all the libc++/libc++abi/libunwind buildbots over > the past year. > - Green Dragon: Ditto, I removed everything and we have Mac builders in > BuildKite. > - GitHubActions: Nobody's using that yet AFAICT. > > I will actually have a talk at the upcoming Dev Meeting where I will > advocate for all projects moving to the same model, since we've had so many > incredible benefits from doing it in libc++ & friends. > > Cheers, > Louis > > >> >> Michael >> > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211019/bfa44b44/attachment.html>
Louis Dionne via llvm-dev
2021-Oct-20 16:56 UTC
[llvm-dev] Upcoming change with how libc++, libc++abi and libunwind are being built
On Tue, Oct 19, 2021 at 1:39 PM Mehdi AMINI <joker.eph at gmail.com> wrote:> > > On Tue, Oct 19, 2021 at 9:37 AM Louis Dionne via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> >> >> On Tue, Oct 19, 2021 at 12:45 AM Michael Kruse <llvmdev at meinersbur.de> >> wrote: >> >>> Am Mo., 18. Okt. 2021 um 15:19 Uhr schrieb Louis Dionne < >>> ldionne.2 at gmail.com>: >>> > Nowadays, we handle all libc++'s own build bots through BuildKite at >>> https://buildkite.com/llvm-project/libcxx-ci. >>> >>> I didn't know. Good that there is systematic testing, but I am a bit >>> concerned about the fracturing of the CI infrastructure (Buildbot, >>> Green dragon, GitHub actions, Buildkite, ...) >>> >> >> For libc++/libc++abi/libunwind, it's actually quite simple. There's >> exactly one place to look, and it's BuildKite. And it runs systematically >> on all changes. >> > > Did you find a solution for having blamelist and blame emails on > BuildKite? >No, but I haven't tried. My experience so far has been that I've never had the need for a blamelist. Since we test everything pre-commit, you always know when one of your patch fails because you see it before it's been committed, in Phabricator. Actual breakage on main is incredibly rare nowadays and it pretty much only happens when someone (usually myself) is too keen on checking something in before CI is finished (oops!). There's never a lot of suspicious commits on main since the last build, so this isn't a problem we've encountered. I guess your experience can vary based on the commit traffic to the project and how diligent people are at testing everything pre-commit, of course. Louis -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211020/eb0e3587/attachment.html>