Hello 👋🏻 I have a little problem with the current llvm-c version it seems like it is not possible to use it correctly? The reason is that byval and sret seem to require a type attribute which can’t be created in the C api. Someone already wrote a fix for it and that is already in the main repo but it didn’t make it into llvm12. This wasn’t a real problem with llvm11 but now is at it seems to be required for functions to actually work. This is the commit that allows one to make these TypeAttributes: https://github.com/llvm/llvm-project/commit/528f6f7d617757addac9b51dd5bcc1ab1352e9be My request is now to add this as a patch to llvm-c for version 12 if this can be done quicker than a new llvm version (e.g 13). The commit also doesn’t edit anything that’s already there but just adds new functions for type attributes. Almost seems like it slipped under the radar. Best regards, Armin Hamar -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210624/0c2b4dc0/attachment-0001.html>
+Tom Stellard <tstellar at redhat.com> for release/backport things On Thu, Jun 24, 2021 at 11:06 AM Armin Hamar via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Hello 👋🏻 > > I have a little problem with the current llvm-c version it seems like it > is not possible to use it correctly? > > The reason is that byval and sret seem to require a type attribute which > can’t be created in the C api. Someone already wrote a fix for it and that > is already in the main repo but it didn’t make it into llvm12. This wasn’t > a real problem with llvm11 but now is at it seems to be required for > functions to actually work. > > This is the commit that allows one to make these TypeAttributes: > > https://github.com/llvm/llvm-project/commit/528f6f7d617757addac9b51dd5bcc1ab1352e9be > > My request is now to add this as a patch to llvm-c for version 12 if this > can be done quicker than a new llvm version (e.g 13). The commit also > doesn’t edit anything that’s already there but just adds new functions for > type attributes. Almost seems like it slipped under the radar. > > Best regards, > Armin Hamar > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210624/59c95c3b/attachment.html>
On 6/24/21 10:56 AM, Armin Hamar wrote:> Hello 👋🏻 > > I have a little problem with the current llvm-c version it seems like it is not possible to use it correctly? >Can you file a bug for this an put release-12.0.1 in the 'blocks' field. -Tom> The reason is that byval and sret seem to require a type attribute which can’t be created in the C api. Someone already wrote a fix for it and that is already in the main repo but it didn’t make it into llvm12. This wasn’t a real problem with llvm11 but now is at it seems to be required for functions to actually work. > > This is the commit that allows one to make these TypeAttributes: > https://github.com/llvm/llvm-project/commit/528f6f7d617757addac9b51dd5bcc1ab1352e9be <https://github.com/llvm/llvm-project/commit/528f6f7d617757addac9b51dd5bcc1ab1352e9be> > > My request is now to add this as a patch to llvm-c for version 12 if this can be done quicker than a new llvm version (e.g 13). The commit also doesn’t edit anything that’s already there but just adds new functions for type attributes. Almost seems like it slipped under the radar. > > Best regards, > Armin Hamar