Djordje Todorovic via llvm-dev
2021-Jun-04 14:06 UTC
[llvm-dev] RFC: Reducing metadata in LLVM tests
Hi, We are seeing that the LLVM test suite grows every day, so there is always a need for reducing the new tests as well as the old ones. There are tools designed to do that, e.g. [0] and [1]. When an IR (or MIR) test contains Debug Info, the LLVM DI Metadata makes the test obviously longer. Not all of these metadata are always necessary for the test, so reviewers frequently ask patch submitters for a reduced test case in terms of DI Metadata by recommending some tricks described in [2]. The [2] is just a small proposal for a utility tool that will save us some time (when fully implemented) during making the patches as well as when doing code reviews -- any thoughts on this? [0] https://llvm.org/docs/CommandGuide/bugpoint.html [1] https://blog.regehr.org/archives/2109 [2] https://github.com/djolertrk/llvm-metadataburn Best regards, Djordje -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210604/f27d771a/attachment-0001.html>
Adrian Prantl via llvm-dev
2021-Jun-04 17:42 UTC
[llvm-dev] RFC: Reducing metadata in LLVM tests
Hi Djordje, I think something like this would be super useful. Can you explain how it differs from the metadata reduction in bugpoint and to what degree the two share (or could share) code? -- adrian> On Jun 4, 2021, at 7:06 AM, Djordje Todorovic <djordje.todorovic at syrmia.com> wrote: > > Hi, > > We are seeing that the LLVM test suite grows every day, so there is always a need for reducing the new tests as well as the old ones. There are tools designed to do that, e.g. [0] and [1]. When an IR (or MIR) test contains Debug Info, the LLVM DI Metadata makes the test obviously longer. Not all of these metadata are always necessary for the test, so reviewers frequently ask patch submitters for a reduced test case in terms of DI Metadata by recommending some tricks described in [2]. The [2] is just a small proposal for a utility tool that will save us some time (when fully implemented) during making the patches as well as when doing code reviews -- any thoughts on this? > > [0] https://llvm.org/docs/CommandGuide/bugpoint.html <https://llvm.org/docs/CommandGuide/bugpoint.html> > [1] https://blog.regehr.org/archives/2109 <https://blog.regehr.org/archives/2109> > [2] https://github.com/djolertrk/llvm-metadataburn <https://github.com/djolertrk/llvm-metadataburn> > > Best regards, > Djordje-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210604/bd2eb24e/attachment.html>