Fāng-ruì Sòng via llvm-dev
2021-Jan-25 18:26 UTC
[llvm-dev] A failure caused by my commits
On Sun, Jan 24, 2021 at 8:35 PM Ben Shi via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > Dear developers, > > A recent call commit by me caused a build failure, due to not enough test. > > Please do not revert it and I will fix it ASAP. > > http://lab.llvm.org:8011/#/builders/109/builds/7148 > > BenSeems that you've reverted it (01d9f13c3a5914baf9739348ef666e348a7b2a2f), but please mention reasons for revert in the future. It was not due to insufficient test. It failed on macOS and Windows and was likely due to platform differences. For `clang -target x86_64` and many other target triples, they behave as generic ELF and should have the same behavior on different OSes. You may need to check why `-target avr` is different on macOS and Windows.
I have reproduced the failures on my ubuntu server. The main reason is, though I tested with removal of avr-gcc, the avr-libc and avr-binutils were not auto removed. I will try the test with all avr-related things removed on both linux and windows. Ben At 2021-01-26 02:26:55, "Fāng-ruì Sòng" <maskray at google.com> wrote:>On Sun, Jan 24, 2021 at 8:35 PM Ben Shi via llvm-dev ><llvm-dev at lists.llvm.org> wrote: >> >> Dear developers, >> >> A recent call commit by me caused a build failure, due to not enough test. >> >> Please do not revert it and I will fix it ASAP. >> >> http://lab.llvm.org:8011/#/builders/109/builds/7148 >> >> Ben > >Seems that you've reverted it >(01d9f13c3a5914baf9739348ef666e348a7b2a2f), but please mention reasons >for revert in the future. > >It was not due to insufficient test. It failed on macOS and Windows >and was likely due to platform differences. > >For `clang -target x86_64` and many other target triples, they behave >as generic ELF and should have the same behavior on different OSes. >You may need to check why `-target avr` is different on macOS and Windows.-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210126/0bc09fd7/attachment.html>