Geoffrey Martin-Noble via llvm-dev
2021-Jan-08 01:05 UTC
[llvm-dev] ExecutionEngine Orc/JITLink Layering issues
Ping on this now that folks are likely back from the holidays :-) On Tue, Dec 29, 2020 at 12:59 PM Geoffrey Martin-Noble <gcmn at google.com> wrote:> I noticed that there appear to be some layering issues in the > ExecutionEngine libraries. The includes between the Orc and JITLink > components have a lot of cycles. From reading > https://groups.google.com/g/llvm-dev/c/uOKEZ-1THf4/m/aHiR5gTOAwAJ it > seems like the goal is for shared components to be in Orc/Shared. Perhaps > more things could move in there > > I made some dot graphs using cinclude2dot. > https://gist.github.com/GMNGeoffrey/2c9818d418a70517f8c628432e1c2447 has > them at the directory level and also one where the include/ and lib/ > directories are merged into a single node. I've also attached the rendered > SVGs. >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210107/a5daaf81/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 3992 bytes Desc: S/MIME Cryptographic Signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210107/a5daaf81/attachment.bin>
Lang Hames via llvm-dev
2021-Jan-18 10:47 UTC
[llvm-dev] ExecutionEngine Orc/JITLink Layering issues
Hi Geoffrey, Sorry for the delayed reply! Yep -- some of this mess crept in while TargetProcess and Shared were being broken out. I start looking at a refactor to sort this out tomorrow, but it might take a little while to untangle. Regards, Lang. On Fri, Jan 8, 2021 at 12:05 PM Geoffrey Martin-Noble <gcmn at google.com> wrote:> Ping on this now that folks are likely back from the holidays :-) > > On Tue, Dec 29, 2020 at 12:59 PM Geoffrey Martin-Noble <gcmn at google.com> > wrote: > >> I noticed that there appear to be some layering issues in the >> ExecutionEngine libraries. The includes between the Orc and JITLink >> components have a lot of cycles. From reading >> https://groups.google.com/g/llvm-dev/c/uOKEZ-1THf4/m/aHiR5gTOAwAJ it >> seems like the goal is for shared components to be in Orc/Shared. Perhaps >> more things could move in there >> >> I made some dot graphs using cinclude2dot. >> https://gist.github.com/GMNGeoffrey/2c9818d418a70517f8c628432e1c2447 has >> them at the directory level and also one where the include/ and lib/ >> directories are merged into a single node. I've also attached the rendered >> SVGs. >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210118/cd83ab7c/attachment.html>