Arthur Eubanks via llvm-dev
2020-Sep-18 20:11 UTC
[llvm-dev] Removing DeadInstEliminationPass
DeadInstEliminationPass is like DeadCodeEliminationPass but it only does one pass through a function instead of iterating on users of eliminated instructions. The reason I'd like to remove this is because it isn't ported to the new pass manager, and it doesn't seem very useful when DeadCodeEliminationPass exists. It also doesn't have very many appearances in tests compared to DCE. Removing in https://reviews.llvm.org/D87933 Any objections? -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200918/7e2e611d/attachment.html>
Johannes Doerfert via llvm-dev
2020-Sep-18 20:20 UTC
[llvm-dev] Removing DeadInstEliminationPass
Nothing comes to mind where DCE isn't a proper replacement, I'm in favor. On 9/18/20 3:11 PM, Arthur Eubanks via llvm-dev wrote:> DeadInstEliminationPass is like DeadCodeEliminationPass but it only does > one pass through a function instead of iterating on users of eliminated > instructions. > > The reason I'd like to remove this is because it isn't ported to the new > pass manager, and it doesn't seem very useful when DeadCodeEliminationPass > exists. It also doesn't have very many appearances in tests compared to DCE. > > Removing in https://reviews.llvm.org/D87933 > > Any objections? > > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Chris Lattner via llvm-dev
2020-Sep-19 00:33 UTC
[llvm-dev] Removing DeadInstEliminationPass
SGTM, this (like the old constprop pass) isn’t used by anything I’m aware of. -Chris> On Sep 18, 2020, at 1:11 PM, Arthur Eubanks via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > DeadInstEliminationPass is like DeadCodeEliminationPass but it only does one pass through a function instead of iterating on users of eliminated instructions. > > The reason I'd like to remove this is because it isn't ported to the new pass manager, and it doesn't seem very useful when DeadCodeEliminationPass exists. It also doesn't have very many appearances in tests compared to DCE. > > Removing in https://reviews.llvm.org/D87933 <https://reviews.llvm.org/D87933> > > Any objections? > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200918/66dc95fb/attachment.html>