Renato Golin via llvm-dev
2020-Sep-16 09:15 UTC
[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?
On Wed, 16 Sep 2020 at 09:37, Anton Korobeynikov via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Apparently reviewable.io requests full permissions to control the > repository and its settings. >I noticed that, too. I guess that if it wants to keep a full history of all force-rebases it may need to create sub-branches for the pull requests, as well as to approve pull requests themselves, which need at least write access. I personally found the interface very confusing, but that could just be that I'm not used to it. However, that also means other people may be put out by the tool and avoid contributing... -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200916/15a838c6/attachment.html>
Stella Laurenzo via llvm-dev
2020-Sep-16 13:22 UTC
[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?
On Wed, Sep 16, 2020, 2:16 AM Renato Golin <rengolin at gmail.com> wrote:> On Wed, 16 Sep 2020 at 09:37, Anton Korobeynikov via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Apparently reviewable.io requests full permissions to control the >> repository and its settings. >> > > I noticed that, too. > > I guess that if it wants to keep a full history of all force-rebases it > may need to create sub-branches for the pull requests, as well as to > approve pull requests themselves, which need at least write access. > > I personally found the interface very confusing, but that could just be > that I'm not used to it. However, that also means other people may be put > out by the tool and avoid contributing... >I'm not sure on this either yet. Preliminarily, as someone who first used phab within the last couple of years, the "this isn't what I'm used to" hurdle wasn't greater than my memory of getting up to speed on the phab flow. But, with a total of two reviews drafted, I'm hardly at the point of advocating for it -- but I did find the experience positive. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200916/e648f4fc/attachment.html>
Renato Golin via llvm-dev
2020-Sep-16 14:14 UTC
[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?
On Wed, 16 Sep 2020 at 14:23, Stella Laurenzo <stellaraccident at gmail.com> wrote:> I'm not sure on this either yet. Preliminarily, as someone who first used > phab within the last couple of years, the "this isn't what I'm used to" > hurdle wasn't greater than my memory of getting up to speed on the phab > flow. But, with a total of two reviews drafted, I'm hardly at the point of > advocating for it -- but I did find the experience positive. >That's great feedback, thanks! -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200916/aa7836f9/attachment.html>