Daniel Martín via llvm-dev
2020-Sep-13 11:28 UTC
[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?
Fangrui Song via cfe-dev <cfe-dev at lists.llvm.org> writes:> > One property of "Squash and merge" is that it will add intermediate > commits as bullet points (`* `). In many cases the merger does not spend > more time cleaning up the description so a commit may look like: > > ``` > RFC: treat small negative λ as 0 for sqrt(::Hermitian) (#35057) > > * treat small negative λ as 0 for sqrt(::Hermitian) and log(::Hermitian) > > * typo > > * added tests, docs; removed rtol argument for log > > * don't ask for rtol so close to eps(Float64) > ```There are some inelegant ways to workaround that problem (see, for example, https://github.com/material-foundation/github-squash-and-merge-pr-descriptions if you are using Chrome). I think I suggested GitHub some time ago that they should at least give the option to include the PR description in the squashed commit description, but I got no response yet.
Daniel Martín via llvm-dev
2020-Sep-13 14:38 UTC
[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?
Renato Golin <rengolin at gmail.com> writes:> > Don't they give you the opportunity to amend the commit message, at least? I vaguely remember it's possible. >If you mean "amend" like in "git commit --amend", it's generally a bad idea to rewrite repository history that has already been published. If you mean "amend" the message in the Web UI before merging, then yes, they let you change the message, but it's very easy to forget to do that. It's not a scalable workflow given the size of the LLVM project, unless there's some automation for it, IMHO.