Paul C. Anagnostopoulos via llvm-dev
2020-Sep-12 21:34 UTC
[llvm-dev] I've gone and broken the build
Aha, I think I see what is going on. Commit e8e3693 should not have been pushed. I must have forgotten to --amend that commit with the second one, 93b4f853. I must learn to do a 'git log' to check for that mistake. My apologies. I do not know how to fix this problem.
Hi Paul, If you setup the git hook as indicated here: https://llvm.org/docs/GettingStarted.html#git-pre-push-hook ; it'll ask for confirmation before pushing multiple commits. Also the section right before gives the manual recipe before pushing: # Check that the list of commits about to be pushed is correct.% git log origin/master...HEAD --oneline -- Mehdi On Sat, Sep 12, 2020 at 2:34 PM Paul C. Anagnostopoulos via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Aha, I think I see what is going on. Commit e8e3693 should not have been > pushed. I must have forgotten to --amend that commit with the second one, > 93b4f853. I must learn to do a 'git log' to check for that mistake. > > My apologies. I do not know how to fix this problem. > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200912/d6b2dd93/attachment.html>
Paul C. Anagnostopoulos via llvm-dev
2020-Sep-12 23:32 UTC
[llvm-dev] I've gone and broken the build
At 9/12/2020 06:00 PM, Mehdi AMINI wrote:>Hi Paul, > >If you setup the git hook as indicated here: <https://llvm.org/docs/GettingStarted.html#git-pre-push-hook>https://llvm.org/docs/GettingStarted.html#git-pre-push-hook ; it'll ask for confirmation before pushing multiple commits. > >Also the section right before gives the manual recipe before pushing: > > ># Check that the list of commits about to be pushed is correct. >% git log origin/master...HEAD --onelineYes, I know I should do the 'git log'. Now I just have to force myself into the right habits. I have an alias to make it easier. I'm on Windows. Is there a way to set up that hook?