Could someone give me the best sequence of git commands to push a patch, now that I have commit access? The document "Code Reviews with Phabricator" says "If you have commit access, there are multiple workflows to commit the change." I presume that I first do a fast-forward merge of the patch onto my master branch. But I'm not sure where to go from there.
I have no experience with arc that automates a few things as the doc explains, but I just use a "git push origin master". You should definitely first do a rebase and a check before doing that, but I think you'll get an error saying that you can't submit your change if you're not up to date. Cheers. ________________________________ From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Paul C. Anagnostopoulos via llvm-dev <llvm-dev at lists.llvm.org> Sent: 07 September 2020 15:17 To: llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org> Subject: [llvm-dev] Pushing a patch Could someone give me the best sequence of git commands to push a patch, now that I have commit access? The document "Code Reviews with Phabricator" says "If you have commit access, there are multiple workflows to commit the change." I presume that I first do a fast-forward merge of the patch onto my master branch. But I'm not sure where to go from there. _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200907/2a734a65/attachment.html>
Hi Paul, This section of the doc (and the following) may be useful: https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git ? -- Mehdi On Mon, Sep 7, 2020 at 7:22 AM Paul C. Anagnostopoulos via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Could someone give me the best sequence of git commands to push a patch, > now that I have commit access? The document "Code Reviews with Phabricator" > says "If you have commit access, there are multiple workflows to commit the > change." > > I presume that I first do a fast-forward merge of the patch onto my master > branch. But I'm not sure where to go from there. > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200907/ea6344c6/attachment.html>