llvm dev - Apr 2020 - Make llvm-commits default cc on Phabricator

Hello,

I sometime forget to set the "Repository" when uploading a patch on
Phabricator, and that prevents from adding llvm-commits as a subscriber.
[cid:image001.png at 01D61A45.E388B060]

Would it make sense to set 'LLVM Github Monorepo' as a default? Or
subscribe 'llvm-commits' automatically when creating a patch?

Thanks!
Alex.

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200424/1252adef/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 3097 bytes
Desc: image001.png
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200424/1252adef/attachment.png>

On Fri, Apr 24, 2020 at 9:43 PM Alexandre Ganea via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> Hello,
>
>
>
> I sometime forget to set the “Repository” when uploading a patch on
> Phabricator, and that prevents from adding llvm-commits as a subscriber.
>
>
>
> Would it make sense to set ‘LLVM Github Monorepo’ as a default?
>
+1 Now that git monorepo is the one true source of truth that is the only
sane default.

> Or subscribe ‘llvm-commits’ automatically when creating a patch?
>
I think that would also make sense.

Thanks!
>
> Alex.
>
Roman

> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200424/38e6eec7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 3097 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200424/38e6eec7/attachment.png>

+1


Another problem of not setting “Repository”  to `rG LLVM Github Monorepo`
is: the patch generated by `Download Raw Diff` will NOT be a "real"
patch.


It won't contain `diff --git ` commands, so you can NOT apply it directly.



Best,

Jinsong Ji (纪金松), PhD.

XL/LLVM on Power Compiler Development
E-mail: jji at us.ibm.com



From:	Roman Lebedev via llvm-dev <llvm-dev at lists.llvm.org>
To:	Alexandre Ganea <alexandre.ganea at ubisoft.com>
Cc:	LLVM Dev <llvm-dev at lists.llvm.org>
Date:	04/24/2020 02:46 PM
Subject:	[EXTERNAL] Re: [llvm-dev] Make llvm-commits default cc on
            Phabricator
Sent by:	"llvm-dev" <llvm-dev-bounces at lists.llvm.org>



On Fri, Apr 24, 2020 at 9:43 PM Alexandre Ganea via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
  Hello,





  I sometime forget to set the “Repository” when uploading a patch on
  Phabricator, and that prevents from adding llvm-commits as a subscriber.








  Would it make sense to set ‘LLVM Github Monorepo’ as a default?


+1 Now that git monorepo is the one true source of truth that is the only
sane default.

  Or subscribe ‘llvm-commits’ automatically when creating a patch?


I think that would also make sense.

  Thanks!


  Alex.


Roman

  _______________________________________________
  LLVM Developers mailing list
  llvm-dev at lists.llvm.org
  https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
  _______________________________________________
  LLVM Developers mailing list
  llvm-dev at lists.llvm.org
 
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=DvnnfavFQBGT2CDyHzTr_Q&m=-50VDf3xr1TCxsA_-5YTBODQdX4w4-dbqvMah_YD3K0&s=24zVYhaeBrhFEJBkoryFiy4kohXxL7w-RgnrZfk7gpk&e


-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200424/c3d77285/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200424/c3d77285/attachment.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 48351733.gif
Type: image/gif
Size: 3097 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200424/c3d77285/attachment-0001.gif>

Hi,

I thought we already had a rule subscribing llvm-commits, but I can't find
it?
I created a new here: https://reviews.llvm.org/H615 and it worked
immediately with Arc but is actually didn't originally when uploading a
diff on the web interface.
I had to tweak the regex many times to get it to match, it seems like there
are whitespace in front of the path when you don't use `arc`, I settled
with @^\s*/llvm/@ right now.

-- 
Mehdi


On Fri, Apr 24, 2020 at 11:42 AM Alexandre Ganea via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> Hello,
>
>
>
> I sometime forget to set the “Repository” when uploading a patch on
> Phabricator, and that prevents from adding llvm-commits as a subscriber.
>
>
>
> Would it make sense to set ‘LLVM Github Monorepo’ as a default? Or
> subscribe ‘llvm-commits’ automatically when creating a patch?
>
>
>
> Thanks!
>
> Alex.
>
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200425/bbca1437/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 3097 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200425/bbca1437/attachment.png>

If you set the repository to LLVM, then Phab will automatically cc llvm-commits.
I also thought there was something in Herald about looking at the path.  I see
Herald adding cfe-commits and lldb-commits to some cross-project reviews, in a
quick check.

I DO NOT want llvm-commits cc’d on *all* Phab reviews.  In particular, clang and
lldb have their own -commits lists, and possibly others. llvm-commits is already
very busy and adding other projects to it will not help reviewers.  llvm-commits
should be for llvm proper, and other sub-projects that don’t have their own list
(e.g., lld).
--paulr


From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Mehdi
AMINI via llvm-dev
Sent: Sunday, April 26, 2020 1:42 AM
To: Alexandre Ganea <alexandre.ganea at ubisoft.com>
Cc: LLVM Dev <llvm-dev at lists.llvm.org>
Subject: Re: [llvm-dev] Make llvm-commits default cc on Phabricator

Hi,

I thought we already had a rule subscribing llvm-commits, but I can't find
it?
I created a new here: https://reviews.llvm.org/H615 and it worked immediately
with Arc but is actually didn't originally when uploading a diff on the web
interface.
I had to tweak the regex many times to get it to match, it seems like there are
whitespace in front of the path when you don't use `arc`, I settled with
@^\s*/llvm/@ right now.

--
Mehdi


On Fri, Apr 24, 2020 at 11:42 AM Alexandre Ganea via llvm-dev <llvm-dev at
lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:
Hello,

I sometime forget to set the “Repository” when uploading a patch on Phabricator,
and that prevents from adding llvm-commits as a subscriber.
[cid:image001.png at 01D61C73.B63F3220]

Would it make sense to set ‘LLVM Github Monorepo’ as a default? Or subscribe
‘llvm-commits’ automatically when creating a patch?

Thanks!
Alex.

_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200427/238fd62c/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 3097 bytes
Desc: image001.png
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200427/238fd62c/attachment-0001.png>