Stefanos Baziotis via llvm-dev
2020-Mar-01 14:44 UTC
[llvm-dev] Commits as new contributor
Hi everyone, I recently was granted commit access, but I'm not really sure what is the process. The developer policy states: "You are granted *commit-after-approval* to all parts of LLVM. To get approval, submit a patch <https://llvm.org/docs/DeveloperPolicy.html#patch> to llvm-commits <http://lists.llvm.org/mailman/listinfo/llvm-commits>. When approved, you may commit it yourself." Do I have to send the patch to llvm-commits via email and wait for approval even when the patch has been accepted in the reviews (i.e. Phabricator) ? Best, Stefanos -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200301/8a593634/attachment.html>
Hi, the docs are assuming that the llvm-commits mailing list is the primary location where the review takes place. Phabricator was added as a helper, and will also send all comments to llvm-commits. In practice, llvm-commits has too much traffic, so only few people will look at llvm-commits. Review takes place almost exclusively on Phabricator. That is, do as you did before. The only change with commit access is that instead of requesting someone to commit for you, you can push your commit yourself to github after a LGTM/approval on Phabricator. The approval has already been sent to llvm-commits by Phabricator. Michael Am So., 1. März 2020 um 08:44 Uhr schrieb Stefanos Baziotis via llvm-dev <llvm-dev at lists.llvm.org>:> > Hi everyone, > > I recently was granted commit access, but I'm not really sure what is the process. > The developer policy states: > "You are granted commit-after-approval to all parts of LLVM. To get approval, submit a patch to llvm-commits. When approved, you may commit it yourself." > > Do I have to send the patch to llvm-commits via email and wait for approval even when the patch has been accepted in the reviews (i.e. Phabricator) ? > > Best, > Stefanos > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Hi,> On 1 Mar 2020, at 14:44, Stefanos Baziotis via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > I recently was granted commit access, but I'm not really sure what is the process. > The developer policy states: > "You are granted commit-after-approval to all parts of LLVM. To get approval, submit a patch to llvm-commits. When approved, you may commit it yourself." > > Do I have to send the patch to llvm-commits via email and wait for approval even when the patch has been accepted in the reviews (i.e. Phabricator) ? >Approval via Phabricator is fine. LLVM-commits (or the relevant sub project list) should always be a subscriber of reviews in Phabricator, so the approval is recorded there too. It may be worth updating the wording in the docs to explicitly mention Phabricator. Cheers Florian -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200301/247a6aec/attachment.html>
Stefanos Baziotis via llvm-dev
2020-Mar-01 15:58 UTC
[llvm-dev] Commits as new contributor
Thanks to both! I'll update the docs. Best, Stefanos Στις Κυρ, 1 Μαρ 2020 στις 5:24 μ.μ., ο/η Florian Hahn < florian_hahn at apple.com> έγραψε:> Hi, > > > On 1 Mar 2020, at 14:44, Stefanos Baziotis via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > I recently was granted commit access, but I'm not really sure what is the > process. > The developer policy states: > "You are granted *commit-after-approval* to all parts of LLVM. To get > approval, submit a patch > <https://llvm.org/docs/DeveloperPolicy.html#patch> to llvm-commits > <http://lists.llvm.org/mailman/listinfo/llvm-commits>. When approved, you > may commit it yourself." > > Do I have to send the patch to llvm-commits via email and wait for > approval even when the patch has been accepted in the reviews (i.e. > Phabricator) ? > > > > Approval via Phabricator is fine. LLVM-commits (or the relevant sub > project list) should always be a subscriber of reviews in Phabricator, so > the approval is recorded there too. > > It may be worth updating the wording in the docs to explicitly mention > Phabricator. > > Cheers > Florian >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200301/5a2ce947/attachment-0001.html>