Chikin, Artem via llvm-dev
2019-Jul-23 15:40 UTC
[llvm-dev] RFC: changing variable naming rules in LLVM codebase & git-blame
This will be a git feature in git 2.23 (in Q3 2019). It will allow git blame to ignore revisions with --ignore-rev, which the user can even specify in their git config. Relevant git blame documentation change: https://github.com/git/git/blob/ae3f36dea16e51041c56ba9ed6b38380c8421816/Documentation/blame-options.txt#L113-L125 Relevant git config documentation change: https://github.com/git/git/blob/ae3f36dea16e51041c56ba9ed6b38380c8421816/Documentation/config/blame.txt#L23-L28 -----Original Message----- From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Peter Waller via llvm-dev Sent: Tuesday, July 23, 2019 11:25 To: llvm-dev at lists.llvm.org Cc: nd <nd at arm.com> Subject: Re: [llvm-dev] RFC: changing variable naming rules in LLVM codebase & git-blame On 7/22/19 6:34 PM, JF Bastien via llvm-dev wrote:> * How do we expect to maintain git blame history, if at all?Hmm. I was hoping git-blame would have a feature which might allow ignoring commits, but seemingly not. You can ignore whitespace changes with -w, but of course that doesn't help for variable names. It seems the next best thing is to blame starting at a revision. At least if there is "one big change", there is only one revision to consider. With many smaller changes that would be harder. _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
John McCall via llvm-dev
2019-Jul-23 16:46 UTC
[llvm-dev] RFC: changing variable naming rules in LLVM codebase & git-blame
On 23 Jul 2019, at 11:40, Chikin, Artem via llvm-dev wrote:> This will be a git feature in git 2.23 (in Q3 2019). > It will allow git blame to ignore revisions with --ignore-rev, which > the user can even specify in their git config.This is great news. Is there a way for a repository to seed this? Maybe a way to (non-canonically?) tag a commit as being good to ignore by default? John.> > Relevant git blame documentation change: > https://github.com/git/git/blob/ae3f36dea16e51041c56ba9ed6b38380c8421816/Documentation/blame-options.txt#L113-L125 > > Relevant git config documentation change: > https://github.com/git/git/blob/ae3f36dea16e51041c56ba9ed6b38380c8421816/Documentation/config/blame.txt#L23-L28 > > -----Original Message----- > From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Peter > Waller via llvm-dev > Sent: Tuesday, July 23, 2019 11:25 > To: llvm-dev at lists.llvm.org > Cc: nd <nd at arm.com> > Subject: Re: [llvm-dev] RFC: changing variable naming rules in LLVM > codebase & git-blame > > On 7/22/19 6:34 PM, JF Bastien via llvm-dev wrote: >> * How do we expect to maintain git blame history, if at all? > > Hmm. I was hoping git-blame would have a feature which might allow > ignoring commits, but seemingly not. You can ignore whitespace changes > with -w, but of course that doesn't help for variable names. > > It seems the next best thing is to blame starting at a revision. At > least if there is "one big change", there is only one revision to > consider. With many smaller changes that would be harder. > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
David Zarzycki via llvm-dev
2019-Jul-24 08:36 UTC
[llvm-dev] RFC: changing variable naming rules in LLVM codebase & git-blame
If I’m reading the docs correctly, the community can designate a file in the repository to hold this information and then users can opt into the database by setting “blame.ignoreRevsFile” in .git/config point at that file.> On Jul 23, 2019, at 5:46 PM, John McCall via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 23 Jul 2019, at 11:40, Chikin, Artem via llvm-dev wrote: >> This will be a git feature in git 2.23 (in Q3 2019). >> It will allow git blame to ignore revisions with --ignore-rev, which the user can even specify in their git config. > > This is great news. Is there a way for a repository to seed this? Maybe a way to (non-canonically?) tag a commit as being good to ignore by default? > > John. > >> >> Relevant git blame documentation change: >> https://github.com/git/git/blob/ae3f36dea16e51041c56ba9ed6b38380c8421816/Documentation/blame-options.txt#L113-L125 >> >> Relevant git config documentation change: >> https://github.com/git/git/blob/ae3f36dea16e51041c56ba9ed6b38380c8421816/Documentation/config/blame.txt#L23-L28 >> >> -----Original Message----- >> From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Peter Waller via llvm-dev >> Sent: Tuesday, July 23, 2019 11:25 >> To: llvm-dev at lists.llvm.org >> Cc: nd <nd at arm.com> >> Subject: Re: [llvm-dev] RFC: changing variable naming rules in LLVM codebase & git-blame >> >> On 7/22/19 6:34 PM, JF Bastien via llvm-dev wrote: >>> * How do we expect to maintain git blame history, if at all? >> >> Hmm. I was hoping git-blame would have a feature which might allow ignoring commits, but seemingly not. You can ignore whitespace changes with -w, but of course that doesn't help for variable names. >> >> It seems the next best thing is to blame starting at a revision. At least if there is "one big change", there is only one revision to consider. With many smaller changes that would be harder. >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev