Hans Wennborg via llvm-dev
2019-Feb-25 15:58 UTC
[llvm-dev] [cfe-dev] [8.0.0 Release] Need help with PR40761: Sanitizers broken on FreeBSD
Many thanks for digging into this, and sorry for my slow reply. Kamil: it sounds like your commit is involved here. Any idea what's happening? Dimitry: If we don't find anyone to debug and fix this before the release, how bad is it for FreeBSD? Can it be worked around downstream if 8.0.0 ships without a fix? Since I'm not entirely sure how supported this functionality is on FreeBSD, I'm not sure how much we should block the release on it. Kim: If you can bisect to find that $somewhere revision, that would be very helpful. Thanks, Hans On Sun, Feb 24, 2019 at 11:36 AM Kim Gräsman <kim.grasman at gmail.com> wrote:> > Hi again, > > It took me a while to get the environment up and running. Turns out > the sanitizer test suite is in pretty bad shape overall on FreeBSD. > > The target reproducing the DEADLYSIGNAL loop is check-asan-dynamic. > > I ran the bisect all the way from release/7.x to release/8.x -- > > * release/7.x - normal test run > * $somewhere - another hang bug where the lit invocation stops dead > immediately after warning about %shared_libasan: > > llvm-lit: /home/kimgr/code/llvm-project/compiler-rt/test/asan/lit.cfg:110: > warning: %shared_libasan substitution not set but dynamic ASan is > available. > > * 342d03e71fbc302cf5a1683dcd03c366bf96d4bb (Reimplement Thread Static > Data ASan routines with TLS) - AddressSanitizer:DEADLYSIGNAL > > The DEADLYSIGNAL behavior is in fact introduced by > https://reviews.llvm.org/D55596. But it looks like FreeBSD was broken > even before this. I'll see if I can bisect where $somewhere is. > > - Kim > > On Fri, Feb 22, 2019 at 1:39 PM Hans Wennborg <hans at chromium.org> wrote: > > > > That's excellent! > > > > I think the check-sanitizer target should cover it. > > > > Thanks, > > Hans > > > > On Fri, Feb 22, 2019 at 1:34 PM Kim Gräsman <kim.grasman at gmail.com> wrote: > > > > > > Hi Hans, > > > > > > I have a freebsd machine and some time to spare this weekend. > > > > > > Could you offer the minimal git bisect command to repro? I'm hoping not to have to run the full check-clang test suite if there's a smaller subset of tests for ASAN. > > > > > > Thanks, > > > - Kim > > > > > > On Thu, Feb 21, 2019, 11:27 Hans Wennborg via cfe-dev <cfe-dev at lists.llvm.org> wrote: > > >> > > >> I think the release is looking pretty good, but there is one blocker > > >> that's worrying me: https://llvm.org/PR40761 > > >> > > >> From what I understand, ASan et al. used to work on FreeBSD but don't > > >> anymore, and there's nobody working on it. > > >> > > >> Is there someone who has access to a FreeBSD machine that could help > > >> investigate this? Just getting it bisected would be super helpful. > > >> > > >> Thanks, > > >> Hans > > >> _______________________________________________ > > >> cfe-dev mailing list > > >> cfe-dev at lists.llvm.org > > >> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Kim Gräsman via llvm-dev
2019-Feb-25 17:29 UTC
[llvm-dev] [cfe-dev] [8.0.0 Release] Need help with PR40761: Sanitizers broken on FreeBSD
Hans, On Mon, Feb 25, 2019 at 4:58 PM Hans Wennborg <hans at chromium.org> wrote:> > Many thanks for digging into this, and sorry for my slow reply. > > Kamil: it sounds like your commit is involved here. Any idea what's happening? > > Dimitry: If we don't find anyone to debug and fix this before the > release, how bad is it for FreeBSD? Can it be worked around downstream > if 8.0.0 ships without a fix? Since I'm not entirely sure how > supported this functionality is on FreeBSD, I'm not sure how much we > should block the release on it. > > Kim: If you can bisect to find that $somewhere revision, that would be > very helpful.It *just* finished. The revision that introduced the hanging is: b85b15d64acb303a56a79ad514d24d46fbe12612 - Don't trigger sanitizer initialization from `sysctlbyname` and `sysctl` interceptor. - r349402 - https://reviews.llvm.org/D55711 - Kim
Kim Gräsman via llvm-dev
2019-Feb-25 17:59 UTC
[llvm-dev] [cfe-dev] [8.0.0 Release] Need help with PR40761: Sanitizers broken on FreeBSD
I'm not really in a position to have an opinion :), but it seems it would be useful if check-.* on FreeBSD didn't hang -- it's hard to judge the quality of anything if the test suite never finishes. I'm guessing the sanitizer tests have never been 100% successful on FreeBSD, but now we don't even get a result. - Kim On Mon, Feb 25, 2019 at 6:29 PM Kim Gräsman <kim.grasman at gmail.com> wrote:> > Hans, > > On Mon, Feb 25, 2019 at 4:58 PM Hans Wennborg <hans at chromium.org> wrote: > > > > Many thanks for digging into this, and sorry for my slow reply. > > > > Kamil: it sounds like your commit is involved here. Any idea what's happening? > > > > Dimitry: If we don't find anyone to debug and fix this before the > > release, how bad is it for FreeBSD? Can it be worked around downstream > > if 8.0.0 ships without a fix? Since I'm not entirely sure how > > supported this functionality is on FreeBSD, I'm not sure how much we > > should block the release on it. > > > > Kim: If you can bisect to find that $somewhere revision, that would be > > very helpful. > > It *just* finished. The revision that introduced the hanging is: > > b85b15d64acb303a56a79ad514d24d46fbe12612 - Don't trigger sanitizer > initialization from `sysctlbyname` and `sysctl` interceptor. - > r349402 - https://reviews.llvm.org/D55711 > > - Kim
Dimitry Andric via llvm-dev
2019-Feb-26 06:45 UTC
[llvm-dev] [cfe-dev] [8.0.0 Release] Need help with PR40761: Sanitizers broken on FreeBSD
On 25 Feb 2019, at 16:58, Hans Wennborg <hans at chromium.org> wrote:> > Many thanks for digging into this, and sorry for my slow reply. > > Kamil: it sounds like your commit is involved here. Any idea what's happening? > > Dimitry: If we don't find anyone to debug and fix this before the > release, how bad is it for FreeBSD? Can it be worked around downstream > if 8.0.0 ships without a fix?I regularly apply post-release patches, so that should be no problem.> Since I'm not entirely sure how > supported this functionality is on FreeBSD, I'm not sure how much we > should block the release on it.No, let's not block the release on it. As far as I can see, mainly the "asan-dynamic" use case is broken, and I am unsure how much that is used. -Dimitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 223 bytes Desc: Message signed with OpenPGP URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190226/9c9b627e/attachment.sig>
Hans Wennborg via llvm-dev
2019-Feb-26 10:55 UTC
[llvm-dev] [cfe-dev] [8.0.0 Release] Need help with PR40761: Sanitizers broken on FreeBSD
On Tue, Feb 26, 2019 at 7:49 AM Dimitry Andric <dimitry at andric.com> wrote:> > On 25 Feb 2019, at 16:58, Hans Wennborg <hans at chromium.org> wrote: > > > > Many thanks for digging into this, and sorry for my slow reply. > > > > Kamil: it sounds like your commit is involved here. Any idea what's happening? > > > > Dimitry: If we don't find anyone to debug and fix this before the > > release, how bad is it for FreeBSD? Can it be worked around downstream > > if 8.0.0 ships without a fix? > > I regularly apply post-release patches, so that should be no problem. > > > > Since I'm not entirely sure how > > supported this functionality is on FreeBSD, I'm not sure how much we > > should block the release on it. > > No, let's not block the release on it. As far as I can see, mainly the > "asan-dynamic" use case is broken, and I am unsure how much that is used.Thanks! That sounds good to me.