Shoaib Meenai via llvm-dev
2019-Feb-13 06:22 UTC
[llvm-dev] Accidental new top-level monorepo directory
https://reviews.llvm.org/rL353906 introduced (presumably accidentally) the "b" top-level directory to the monorepo. The files should be moved to their proper location, but I'm also wondering if there's any way to prevent accidental top-level additions like this. Thanks, Shoaib -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190213/2b548876/attachment.html>
Jonas Devlieghere via llvm-dev
2019-Feb-13 06:47 UTC
[llvm-dev] Accidental new top-level monorepo directory
Hi Shoaib, Thanks for pointing this out. I had not idea this happened or that it was even possible to create top level directories in the monorepo. I assumed everything went through git-svn as it did in the past? I removed the directory again in r353913. I agree that it would be great if this wasn't possible at all. Thanks, Jonas On Tue, Feb 12, 2019 at 10:22 PM Shoaib Meenai <smeenai at fb.com> wrote:> https://reviews.llvm.org/rL353906 introduced (presumably accidentally) > the "b" top-level directory to the monorepo. The files should be moved to > their proper location, but I'm also wondering if there's any way to prevent > accidental top-level additions like this. > > > > Thanks, > > Shoaib >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190212/7206659c/attachment.html>
Tom Stellard via llvm-dev
2019-Feb-13 14:49 UTC
[llvm-dev] Accidental new top-level monorepo directory
On 02/12/2019 10:47 PM, Jonas Devlieghere via llvm-dev wrote:> Hi Shoaib, > > Thanks for pointing this out. I had not idea this happened or that it was even possible to create top level directories in the monorepo. I assumed everything went through git-svn as it did in the past? I removed the directory again in r353913. I agree that it would be great if this wasn't possible at all. >I can look into ways to prevent this from happening. Can you give me a little more information on what happened? Did you add the 'b' directory while doing development and then accidentally commit it or did the monorepo script add it? Did you commit using git or svn? Thanks, Tom> Thanks, > Jonas > > On Tue, Feb 12, 2019 at 10:22 PM Shoaib Meenai <smeenai at fb.com <mailto:smeenai at fb.com>> wrote: > > https://reviews.llvm.org/rL353906 introduced (presumably accidentally) the "b" top-level directory to the monorepo. The files should be moved to their proper location, but I'm also wondering if there's any way to prevent accidental top-level additions like this.____ > > __ __ > > Thanks,____ > > Shoaib____ > > > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >