Zakharin, Vyacheslav P via llvm-dev
2019-Feb-06 01:36 UTC
[llvm-dev] right way for setting PreserveLCSSA with new pass manager
Hi, mustPreserveAnalysisID(LCSSAID) cannot be used with the new pass manager, so what is the right way for querying it? FunctionAnalysisManager::getCachedResult<LCSSAPass>(F) will not work, since LCSSAPass does not have a result. Moreover, it is not an analysis :) Thanks, Slava -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190206/d0d74674/attachment.html>
Philip Pfaffe via llvm-dev
2019-Feb-06 17:31 UTC
[llvm-dev] right way for setting PreserveLCSSA with new pass manager
Hi Slava, we don't preserve LCSSA in the new PM. If you need it you have to rerun LCSAA before your pass. Cheers, Philip On Wed, Feb 6, 2019 at 2:36 AM Zakharin, Vyacheslav P via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Hi, > > > > mustPreserveAnalysisID(LCSSAID) cannot be used with the new pass manager, > so what is the right way for querying it? > FunctionAnalysisManager::getCachedResult<LCSSAPass>(F) will not work, since > LCSSAPass does not have a result. Moreover, it is not an analysis J > > > > Thanks, > > Slava > > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190206/5b84f240/attachment.html>
Zakharin, Vyacheslav P via llvm-dev
2019-Feb-06 17:43 UTC
[llvm-dev] right way for setting PreserveLCSSA with new pass manager
Hi Philip, If I want to use InsertPreheaderForLoop(), I need to pass PreserveLCSSA parameter to it. If I get it right, I should use mustPreserveAnalysisID(LCSSAID) with the old pass manager and pass ‘false’ explicitly with the new pass manager. Does it sound right? Thanks, Slava From: Philip Pfaffe [mailto:philip.pfaffe at gmail.com] Sent: Wednesday, February 6, 2019 9:31 AM To: Zakharin, Vyacheslav P <vyacheslav.p.zakharin at intel.com> Cc: llvm-dev at lists.llvm.org Subject: Re: [llvm-dev] right way for setting PreserveLCSSA with new pass manager Hi Slava, we don't preserve LCSSA in the new PM. If you need it you have to rerun LCSAA before your pass. Cheers, Philip On Wed, Feb 6, 2019 at 2:36 AM Zakharin, Vyacheslav P via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Hi, mustPreserveAnalysisID(LCSSAID) cannot be used with the new pass manager, so what is the right way for querying it? FunctionAnalysisManager::getCachedResult<LCSSAPass>(F) will not work, since LCSSAPass does not have a result. Moreover, it is not an analysis ☺ Thanks, Slava _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190206/98a52559/attachment.html>