Petr Hosek via llvm-dev
2018-Aug-31 20:14 UTC
[llvm-dev] Removing the deprecated __xray_log_init API from XRay FDR logging implementation
I'd like to remove __xray_log_init function together with FDRLoggingOptions and BasicLoggingOptions structs from the XRay FDR logging interface. These functions have been marked as deprecated since May 4, 2018. Now that 7.0 has been branched, I think it should be safe to remove them and it'd make further refactoring that I'm currently working on much easier, but I want to check that all users have already moved away from this API and won't be broken by this change? If nobody raises any objections, I'd send out a change to remove this API. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180831/1a1c3112/attachment.html>
Dean Michael Berris via llvm-dev
2018-Sep-04 00:04 UTC
[llvm-dev] Removing the deprecated __xray_log_init API from XRay FDR logging implementation
+1 from me. Thanks Petr! On Sat, 1 Sep 2018 at 6:14 am, Petr Hosek via llvm-dev < llvm-dev at lists.llvm.org> wrote:> I'd like to remove __xray_log_init function together with > FDRLoggingOptions and BasicLoggingOptions structs from the XRay FDR logging > interface. > > These functions have been marked as deprecated since May 4, 2018. Now that > 7.0 has been branched, I think it should be safe to remove them and it'd > make further refactoring that I'm currently working on much easier, but I > want to check that all users have already moved away from this API and > won't be broken by this change? If nobody raises any objections, I'd send > out a change to remove this API. > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-- Dean -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180904/0f7bcb42/attachment.html>