Hello friends, A couple years back I’ve started a M68K codegen port of LLVM, and then suspended it for the lack of free time. Now I finally got some time and willing to continue working on it. To keep up with LLVM changes I'd like to merge it upstream. There is already patch for it: https://reviews.llvm.org/D50314 <https://reviews.llvm.org/D50314>, but then I was reminded that adding a new backend is not a small thing. So, at this point I require an advice, help or both on how to proceed, and since the patch is quite big I am not sure that a single person would willingly spend time reviewing it entirely. Kind regards, Artyom -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180814/4c7338da/attachment.html>
Hi Artyom, I made a very brief run over the patch and indeed it is quite large :) Will it be possible to split it to enable better review? For example I'm seeing you're having some generic codegenerator / TableGen changes. Will it be possible to separate them out and provide rationale for them? Going further, probably triple and ELF-related changes could be also separated out. On Tue, Aug 14, 2018 at 9:32 PM, Gmail-m4yers via llvm-dev <llvm-dev at lists.llvm.org> wrote:> Hello friends, > > A couple years back I’ve started a M68K codegen port of LLVM, and then > suspended it for the lack of free time. Now I finally got some time and > willing to continue working on it. To keep up with LLVM changes I'd like to > merge it upstream. > > There is already patch for it: https://reviews.llvm.org/D50314, but then I > was reminded that adding a new backend is not a small thing. So, at this > point I require an advice, help or both on how to proceed, and since the > patch is quite big I am not sure that a single person would willingly spend > time reviewing it entirely. > > Kind regards, > Artyom > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-- With best regards, Anton Korobeynikov Department of Statistical Modelling, Saint Petersburg State University
Hi Anton, Thanks for the tip. I’ve moved some common code from the patch: https://reviews.llvm.org/D50784 <https://reviews.llvm.org/D50784> https://reviews.llvm.org/D50856 <https://reviews.llvm.org/D50856> https://reviews.llvm.org/D50858 <https://reviews.llvm.org/D50858> but the backend itself is still quite large. Anything more I can do to simplify reviewing?> On 15 Aug 2018, at 09:33, Anton Korobeynikov <anton at korobeynikov.info> wrote: > > Hi Artyom, > > I made a very brief run over the patch and indeed it is quite large :) > > Will it be possible to split it to enable better review? For example > I'm seeing you're having some generic codegenerator / TableGen > changes. Will it be possible to separate them out and provide > rationale for them? Going further, probably triple and ELF-related > changes could be also separated out. > > > On Tue, Aug 14, 2018 at 9:32 PM, Gmail-m4yers via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> Hello friends, >> >> A couple years back I’ve started a M68K codegen port of LLVM, and then >> suspended it for the lack of free time. Now I finally got some time and >> willing to continue working on it. To keep up with LLVM changes I'd like to >> merge it upstream. >> >> There is already patch for it: https://reviews.llvm.org/D50314, but then I >> was reminded that adding a new backend is not a small thing. So, at this >> point I require an advice, help or both on how to proceed, and since the >> patch is quite big I am not sure that a single person would willingly spend >> time reviewing it entirely. >> >> Kind regards, >> Artyom >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> > > > > -- > With best regards, Anton Korobeynikov > Department of Statistical Modelling, Saint Petersburg State University-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180816/82b81602/attachment-0001.html>