Simon Tatham via llvm-dev
2017-Jun-21 14:36 UTC
[llvm-dev] [LLD][COFF] Zero linker-version header field breaks Authenticode on Windows 7
> From: Rui Ueyama [mailto:ruiu at google.com] > Sent: 21 June 2017 15:23 > > lld-link already has an option to specify version. Please try to add > "/version:14.0" to your command line.That doesn't affect the same version field. The number I put in there goes into the MajorImageVersion and MinorImageVersion fields, whereas to solve this signature issue I need to control MajorLinkerVersion and MinorLinkerVersion. Cheers, Simon
Rui Ueyama via llvm-dev
2017-Jun-21 15:04 UTC
[llvm-dev] [LLD][COFF] Zero linker-version header field breaks Authenticode on Windows 7
Ah, OK. Then I think we should just hard-code the linker so that it sets MajorLinkerVersion to 14. We can make it configurable, but hard-coding should suffice. Do you want to write a patch? I mean it's going to be just a single-line patch, so if you are not familiar with LLVM development process, I can do that for you. On Wed, Jun 21, 2017 at 7:36 AM, Simon Tatham <Simon.Tatham at arm.com> wrote:> > From: Rui Ueyama [mailto:ruiu at google.com] > > Sent: 21 June 2017 15:23 > > > > lld-link already has an option to specify version. Please try to add > > "/version:14.0" to your command line. > > That doesn't affect the same version field. The number I put in there goes > into the MajorImageVersion and MinorImageVersion fields, whereas to solve > this signature issue I need to control MajorLinkerVersion and > MinorLinkerVersion. > > Cheers, > Simon >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170621/17def596/attachment.html>
Simon Tatham via llvm-dev
2017-Jun-21 15:10 UTC
[llvm-dev] [LLD][COFF] Zero linker-version header field breaks Authenticode on Windows 7
> From: Rui Ueyama [mailto:ruiu at google.com] > Sent: 21 June 2017 16:05 > > Ah, OK. Then I think we should just hard-code the linker so that it sets > MajorLinkerVersion to 14.Fair enough.> Do you want to write a patch? I mean it's going to be just a single-line patch, > so if you are not familiar with LLVM development process, I can do that for > you.I haven't interacted with the LLVM development process before, but submitting a nice easy one-line patch seems like an excellent way to start, so I'm happy to do it myself :-) Cheers, SImon