Hi Richard, Marco, I noticed that you two are the remaining bot owners using the `getClangBuildFactory` from `ClangBuilder`. All the other bots using that builder have moved to the new `getClangCMakeBuildFactory`, including Windows ones. Given that they do similar functionalities, I'd like to encourage you to move to the new factory, so that we can simplify the builder's code. Thanks! --renato PS: The builders are: Richard: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2 http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules Marco: http://lab.llvm.org:8011/builders/clang-bpf-build
Marco Leogrande via llvm-dev
2016-Oct-31 18:56 UTC
[llvm-dev] [Zorg] Simplify ClangBuilder
Renato, thanks for the heads-up. For clang-bpf-build the change should be trivial since we don't use a fancy configuration. I have attached the patch, please apply if appropriate. Thanks. Regards, Marco Leogrande Sent by a carbon-based life form; hence, it may contain repetitions, inaccuracies, logical fallacies and repetitions. On Mon, Oct 31, 2016 at 5:14 AM, Renato Golin <renato.golin at linaro.org> wrote:> Hi Richard, Marco, > > I noticed that you two are the remaining bot owners using the > `getClangBuildFactory` from `ClangBuilder`. All the other bots using > that builder have moved to the new `getClangCMakeBuildFactory`, > including Windows ones. > > Given that they do similar functionalities, I'd like to encourage you > to move to the new factory, so that we can simplify the builder's > code. > > Thanks! > --renato > > PS: The builders are: > > Richard: > http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2 > http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules > > Marco: > http://lab.llvm.org:8011/builders/clang-bpf-build-------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-zorg-bpf-Convert-builder-to-use-getClangCMakeBuildFa.patch Type: text/x-patch Size: 1455 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161031/7b3632f3/attachment.bin>
On 31 October 2016 at 18:56, Marco Leogrande <marcol at plumgrid.com> wrote:> For clang-bpf-build the change should be trivial since we don't use a > fancy configuration. > I have attached the patch, please apply if appropriate.I believe it should just work. Galina, can you give it a try? The build should "just work". :) thanks! --renato