Eugene Zelenko via llvm-dev
2016-Sep-20 02:01 UTC
[llvm-dev] Differential: accepted but not closed revisions
Hi! There are a lot of accepted but not closed revisions in Differential. Many of them were actually committed, but without Differential revision link or when it was specified in wrong way. I think will be good idea to create script which will match committed revisions with those in Differential: file list should be same and hashes of changed line could be calculated for each file. In case of incomplete match, human intervention may be needed. This script could close revisions which were made in past and monitor current revisions for mistakes. Eugene.
Johannes Doerfert via llvm-dev
2016-Sep-21 08:32 UTC
[llvm-dev] Differential: accepted but not closed revisions
I really like the idea. I would even use a similar (git) commit hook to fix my commit messages in place. On 09/19, Eugene Zelenko via llvm-dev wrote:> Hi! > > There are a lot of accepted but not closed revisions in Differential. > Many of them were actually committed, but without Differential > revision link or when it was specified in wrong way. > > I think will be good idea to create script which will match committed > revisions with those in Differential: file list should be same and > hashes of changed line could be calculated for each file. In case of > incomplete match, human intervention may be needed. > > This script could close revisions which were made in past and monitor > current revisions for mistakes. > > Eugene. > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-- Johannes Doerfert Researcher / PhD Student Compiler Design Lab (Prof. Hack) Saarland Informatics Campus, Germany Building E1.3, Room 4.31 Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de Fax. +49 (0)681 302-3065 : http://www.cdl.uni-saarland.de/people/doerfert -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 213 bytes Desc: Digital signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160921/b3e8ad55/attachment.sig>
Vitaly Buka via llvm-dev
2016-Oct-04 20:49 UTC
[llvm-dev] Differential: accepted but not closed revisions
Can we make the script to reopen reverted revisions? On Wed, Sep 21, 2016 at 1:32 AM Johannes Doerfert via llvm-dev < llvm-dev at lists.llvm.org> wrote:> I really like the idea. I would even use a similar (git) commit hook to > fix my commit messages in place. > > On 09/19, Eugene Zelenko via llvm-dev wrote: > > Hi! > > > > There are a lot of accepted but not closed revisions in Differential. > > Many of them were actually committed, but without Differential > > revision link or when it was specified in wrong way. > > > > I think will be good idea to create script which will match committed > > revisions with those in Differential: file list should be same and > > hashes of changed line could be calculated for each file. In case of > > incomplete match, human intervention may be needed. > > > > This script could close revisions which were made in past and monitor > > current revisions for mistakes. > > > > Eugene. > > _______________________________________________ > > LLVM Developers mailing list > > llvm-dev at lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > -- > > Johannes Doerfert > Researcher / PhD Student > > Compiler Design Lab (Prof. Hack) > Saarland Informatics Campus, Germany > Building E1.3, Room 4.31 > > Tel. +49 (0)681 302-57521 <+49%20681%2030257521> : > doerfert at cs.uni-saarland.de > Fax. +49 (0)681 302-3065 <+49%20681%203023065> : > http://www.cdl.uni-saarland.de/people/doerfert > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161004/6cef18a7/attachment.html>