llvm dev - Dec 2015 - [compiler-rt] r249514 - builtins: emulate _Complex for cl

On Wed, Oct 07, 2015 at 02:58:07AM -0000, Saleem Abdulrasool via llvm-commits
wrote:
> Author: compnerd
> Date: Tue Oct  6 21:58:07 2015
> New Revision: 249514
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=249514&view=rev
> Log:
> builtins: emulate _Complex for cl
> 
> cl does not support C99 completely as of VS2015.  Emulate _Complex to allow
> building with MSVC.
> 
> Patch by Tee Hao Wei!
Going back to this, I would like to see this reverted and stop us
pretending that we care about a compiler that doesn't even support C99.
The standard is 25 years old, get real. I see absolutely no reason why
we have to add hacks for such basic language features as complex.

Joerg

On Fri, Dec 04, 2015 at 12:36:37AM +0100, Joerg Sonnenberger via llvm-dev
wrote:
> On Wed, Oct 07, 2015 at 02:58:07AM -0000, Saleem Abdulrasool via
llvm-commits wrote:
> > Author: compnerd
> > Date: Tue Oct  6 21:58:07 2015
> > New Revision: 249514
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=249514&view=rev
> > Log:
> > builtins: emulate _Complex for cl
> > 
> > cl does not support C99 completely as of VS2015.  Emulate _Complex to
allow
> > building with MSVC.
> > 
> > Patch by Tee Hao Wei!
> 
> Going back to this, I would like to see this reverted and stop us
> pretending that we care about a compiler that doesn't even support C99.
> The standard is 25 years old, get real. I see absolutely no reason why
> we have to add hacks for such basic language features as complex.
Well, 15 years. Typo :) But still.

Joerg

> Going back to this, I would like to see this reverted and stop us
> pretending that we care about a compiler that doesn't even support C99.
I agree, particularly for our own runtime support library. Maybe this
was added while CMake could only build compiler-rt with the host
compiler?

Tim.