Alex Wang via llvm-dev
2015-Sep-22 16:37 UTC
[llvm-dev] [compiler-rt] Add iOS simulator link flag
Hello all! Just got a small patch I’d like to put up for review. llvm with clang and compiler-rt have been consistently failing for me during the linking step for either the address or ub sanitizer for iOS simulator. As far as I could tell, passing -isysroot to clang++ when linking does not also set the search root for ld. This patch addresses that issue. Unfortunately, the build fails later on, so I can't say for sure whether this won't break anything else, or if it is required elsewhere. I'm also not sure if this is specific to my computer, but it persisted between a wipe + reinstall, so I'm hoping it isn't just me getting this. Thanks, Alex -------------- next part -------------- A non-text attachment was scrubbed... Name: iossim-link-flag.patch Type: application/octet-stream Size: 545 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150922/026d9a81/attachment.obj>
Alexey Samsonov via llvm-dev
2015-Sep-22 19:32 UTC
[llvm-dev] [compiler-rt] Add iOS simulator link flag
Could you describe the build failures you see after applying this patch? I'll let Chris judge if adding -Wl,-syslibroot makes sense for iossim, or that problem should be solved differently. On Tue, Sep 22, 2015 at 9:37 AM, Alex Wang via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Hello all! > > Just got a small patch I’d like to put up for review. > > llvm with clang and compiler-rt have been consistently failing for me > during > the linking step for either the address or ub sanitizer for iOS simulator. > > As far as I could tell, passing -isysroot to clang++ when linking does not > also set the search root for ld. This patch addresses that issue. > > Unfortunately, the build fails later on, so I can't say for sure whether > this won't break anything else, or if it is required elsewhere. I'm also > not sure if this is specific to my computer, but it persisted between a > wipe + reinstall, so I'm hoping it isn't just me getting this. > > Thanks, > Alex > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > >-- Alexey Samsonov vonosmas at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150922/af0cd73b/attachment.html>
Alexey Samsonov via llvm-dev
2015-Sep-22 19:34 UTC
[llvm-dev] [compiler-rt] Add iOS simulator link flag
+llvm-commits (correct list) On Tue, Sep 22, 2015 at 12:32 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:> Could you describe the build failures you see after applying this patch? > I'll let Chris judge if adding -Wl,-syslibroot makes sense for iossim, or > that problem should be solved differently. > > On Tue, Sep 22, 2015 at 9:37 AM, Alex Wang via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Hello all! >> >> Just got a small patch I’d like to put up for review. >> >> llvm with clang and compiler-rt have been consistently failing for me >> during >> the linking step for either the address or ub sanitizer for iOS simulator. >> >> As far as I could tell, passing -isysroot to clang++ when linking does not >> also set the search root for ld. This patch addresses that issue. >> >> Unfortunately, the build fails later on, so I can't say for sure whether >> this won't break anything else, or if it is required elsewhere. I'm also >> not sure if this is specific to my computer, but it persisted between a >> wipe + reinstall, so I'm hoping it isn't just me getting this. >> >> Thanks, >> Alex >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >> > > > -- > Alexey Samsonov > vonosmas at gmail.com >-- Alexey Samsonov vonosmas at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150922/2c282973/attachment.html>