llvm dev - Jun 2015 - [LLVMdev] Request for review: Loss of Sign Checker

Hi,
	I just submitted a patch (Phabricator diff #28096) for a new 'Loss of 
Sign' checker, that would help diagnose the case when a negative value 
is assigned to an unsigned variable. The test case is included.

Unfortunately, there are no existing diagnostics for such assignments 
that lose the sign, which can cause nasty silent runtime failures.

Can someone please review the above changes? Since I do not have commit 
privilege, I would need someone to please help me with committing the 
changes once the review is over.

Please do let me know in case I missed anything.

Thanks,
Soumitra

Hi Soumitra,

I failed to find your patch #28096 in Phabricator.
Maybe it is a wrong id.

Kind regard,
Evgeny Astigeevich


-----Original Message-----
From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On
Behalf Of Soumitra Chatterjee
Sent: 22 June 2015 05:39
To: llvmdev at cs.uiuc.edu
Subject: [LLVMdev] Request for review: Loss of Sign Checker

Hi,
	I just submitted a patch (Phabricator diff #28096) for a new 'Loss
of Sign' checker, that would help diagnose the case when a negative value is
assigned to an unsigned variable. The test case is included.

Unfortunately, there are no existing diagnostics for such assignments that
lose the sign, which can cause nasty silent runtime failures.

Can someone please review the above changes? Since I do not have commit
privilege, I would need someone to please help me with committing the
changes once the review is over.

Please do let me know in case I missed anything.

Thanks,
Soumitra
_______________________________________________
LLVM Developers mailing list
LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

Hi,

If you follow the instruction here http://llvm.org/docs/Phabricator.html and
especially "If your patch is for LLVM, add llvm-commits as a subscriber; if
your patch is for Clang, add cfe-commits”, the patch will be sent automatically
by phabricator to the correct mailing-list (llvm-commits of cfe-commits).

— 
Mehdi
> On Jun 21, 2015, at 9:39 PM, Soumitra Chatterjee <soumitra at hp.com>
wrote:
> 
> Hi,
> 	I just submitted a patch (Phabricator diff #28096) for a new 'Loss of
Sign' checker, that would help diagnose the case when a negative value is
assigned to an unsigned variable. The test case is included.
> 
> Unfortunately, there are no existing diagnostics for such assignments that
lose the sign, which can cause nasty silent runtime failures.
> 
> Can someone please review the above changes? Since I do not have commit
privilege, I would need someone to please help me with committing the changes
once the review is over.
> 
> Please do let me know in case I missed anything.
> 
> Thanks,
> Soumitra
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

Looks like my submission was incomplete and the id I mentioned was hence 
incorrect. Apologies for that.

I *think* I have now completed the submission correctly on Phabricator 
as #D10634: http://reviews.llvm.org/D10634

Thanks,
Soumitra

On 22-Jun-2015 10:09 AM, Soumitra Chatterjee wrote:
> Hi,
>      I just submitted a patch (Phabricator diff #28096) for a new 'Loss
> of Sign' checker, that would help diagnose the case when a negative
> value is assigned to an unsigned variable. The test case is included.
>
> Unfortunately, there are no existing diagnostics for such assignments
> that lose the sign, which can cause nasty silent runtime failures.
>
> Can someone please review the above changes? Since I do not have commit
> privilege, I would need someone to please help me with committing the
> changes once the review is over.
>
> Please do let me know in case I missed anything.
>
> Thanks,
> Soumitra
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev