llvm dev - Jun 2015 - [LLVMdev] Clang-Format all LLVM Projects

Hey,

I would like to ask if it is worth a shot to create a pull request which
basically clang-formats projects like libcxxabi/libunwind ?
Since those projects aren't following the LLVM coding standards.
It would make the code even "more readable" also it would give
"me" the feeling that it actually belongs to the LLVM project.

Thanks
-- Peet

On 7 June 2015 at 14:51, Peet <mezo37 at yandex.com>
wrote:
> I would like to ask if it is worth a shot to create a pull request which
basically clang-formats projects like libcxxabi/libunwind ?
> Since those projects aren't following the LLVM coding standards.
> It would make the code even "more readable" also it would give
"me" the feeling that it actually belongs to the LLVM project.
Hi Peet,

We had this discussion a number of times for different projects and
the general feeling was that it wouldn't be a big problem to do so,
but that also depends on the project's community. I'm copying some of
the main developers of those projects for their view on the matter.

I personally prefer not to format code that hasn't changed, as that
messes up with the version history (git blame and all), but people are
normally less paranoid than I am.

cheers,
--renato

> I personally prefer not to format code that hasn't changed, as that
> messes up with the version history (git blame and all), but people are
> normally less paranoid than I am.
+1

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University

On Sun, Jun 7, 2015 at 9:59 AM, Renato Golin <renato.golin at linaro.org>
wrote:
> On 7 June 2015 at 14:51, Peet <mezo37 at yandex.com> wrote:
> > I would like to ask if it is worth a shot to create a pull request
which
> basically clang-formats projects like libcxxabi/libunwind ?
> > Since those projects aren't following the LLVM coding standards.
> > It would make the code even "more readable" also it would
give "me" the
> feeling that it actually belongs to the LLVM project.
>
> Hi Peet,
>
> We had this discussion a number of times for different projects and
> the general feeling was that it wouldn't be a big problem to do so,
> but that also depends on the project's community. I'm copying some
of
> the main developers of those projects for their view on the matter.
>
> I personally prefer not to format code that hasn't changed, as that
> messes up with the version history (git blame and all), but people are
> normally less paranoid than I am.
>
Normally, I would agree.  However, unless Im mistaken, the splitting of
libunwind did destroy history :-(.  In that case, unless there are
objections from others (I think Nick should be included in this set), I
don't think we loose too much in the specific case of libunwind.   But, I
agree in the case of libc++/libc++abi.

> cheers,
> --renato
>
-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20150612/abd918cf/attachment.html>