Quentin Colombet
2015-Apr-24 21:06 UTC
[LLVMdev] Multiple connected components in live interval
Hi Jonas, I won’t have time to look at it this week after all. I’ll try to do that next week. If you do not hear back from me by end of next, do not hesitate to ping me! Cheers, -Quentin> On Apr 22, 2015, at 9:32 AM, Quentin Colombet <qcolombet at apple.com> wrote: > >> >> On Apr 21, 2015, at 11:49 PM, Jonas Paulsson <jonas.paulsson at ericsson.com <mailto:jonas.paulsson at ericsson.com>> wrote: >> >> I looked at SplitKit, but I am not sure how to best do it, so it would be great if you could take a look. > > Sure. > I will try to do that by the end of the week. > > Cheers, > Q. > >> >> /Jonas >> >> >> On 2015-04-21 19:35, Quentin Colombet wrote: >>>> On Apr 21, 2015, at 7:40 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote: >>>> >>>> >>>>> On Apr 21, 2015, at 05:39, Jonas Paulsson <jonas.paulsson at ericsson.com> wrote: >>>>> >>>>> Could it then be that the RegisterCoalescer should split live ranges when LIS->shrinkToUses() return true? Why does it not do that, when the verifier demands this? >>>> I think it should. That's an oversight. >>> Yep, this is likely the problem. >>> >>> Jonas, do you think you can investigate a fix, or do you want me to look at it? >>> >>> Cheers, >>> -Quentin >> > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu <http://llvm.cs.uiuc.edu/> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev <http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev>-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150424/f049f673/attachment.html>
Quentin Colombet
2015-Apr-29 22:05 UTC
[LLVMdev] Multiple connected components in live interval
Hi Jonas, Could you check if the attached patch fix your problem? Thanks, -Quentin> On Apr 24, 2015, at 2:06 PM, Quentin Colombet <qcolombet at apple.com> wrote: > > Hi Jonas, > > I won’t have time to look at it this week after all. > I’ll try to do that next week. > If you do not hear back from me by end of next, do not hesitate to ping me! > > Cheers, > -Quentin >> On Apr 22, 2015, at 9:32 AM, Quentin Colombet <qcolombet at apple.com <mailto:qcolombet at apple.com>> wrote: >> >>> >>> On Apr 21, 2015, at 11:49 PM, Jonas Paulsson <jonas.paulsson at ericsson.com <mailto:jonas.paulsson at ericsson.com>> wrote: >>> >>> I looked at SplitKit, but I am not sure how to best do it, so it would be great if you could take a look. >> >> Sure. >> I will try to do that by the end of the week. >> >> Cheers, >> Q. >> >>> >>> /Jonas >>> >>> >>> On 2015-04-21 19:35, Quentin Colombet wrote: >>>>> On Apr 21, 2015, at 7:40 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk <mailto:stoklund at 2pi.dk>> wrote: >>>>> >>>>> >>>>>> On Apr 21, 2015, at 05:39, Jonas Paulsson <jonas.paulsson at ericsson.com <mailto:jonas.paulsson at ericsson.com>> wrote: >>>>>> >>>>>> Could it then be that the RegisterCoalescer should split live ranges when LIS->shrinkToUses() return true? Why does it not do that, when the verifier demands this? >>>>> I think it should. That's an oversight. >>>> Yep, this is likely the problem. >>>> >>>> Jonas, do you think you can investigate a fix, or do you want me to look at it? >>>> >>>> Cheers, >>>> -Quentin >>> >> >> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu <http://llvm.cs.uiuc.edu/> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev <http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev> > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150429/1dcf8180/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: multiple_components.patch Type: application/octet-stream Size: 2750 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150429/1dcf8180/attachment.obj> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150429/1dcf8180/attachment-0001.html>
Quentin Colombet
2015-May-06 22:45 UTC
[LLVMdev] Multiple connected components in live interval
Jonas checked that this patch fixes his issue. Committed revision 236658. Q.> On Apr 29, 2015, at 3:05 PM, Quentin Colombet <qcolombet at apple.com> wrote: > > Hi Jonas, > > Could you check if the attached patch fix your problem? > > Thanks, > -Quentin > <multiple_components.patch> > >> On Apr 24, 2015, at 2:06 PM, Quentin Colombet <qcolombet at apple.com <mailto:qcolombet at apple.com>> wrote: >> >> Hi Jonas, >> >> I won’t have time to look at it this week after all. >> I’ll try to do that next week. >> If you do not hear back from me by end of next, do not hesitate to ping me! >> >> Cheers, >> -Quentin >>> On Apr 22, 2015, at 9:32 AM, Quentin Colombet <qcolombet at apple.com <mailto:qcolombet at apple.com>> wrote: >>> >>>> >>>> On Apr 21, 2015, at 11:49 PM, Jonas Paulsson <jonas.paulsson at ericsson.com <mailto:jonas.paulsson at ericsson.com>> wrote: >>>> >>>> I looked at SplitKit, but I am not sure how to best do it, so it would be great if you could take a look. >>> >>> Sure. >>> I will try to do that by the end of the week. >>> >>> Cheers, >>> Q. >>> >>>> >>>> /Jonas >>>> >>>> >>>> On 2015-04-21 19:35, Quentin Colombet wrote: >>>>>> On Apr 21, 2015, at 7:40 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk <mailto:stoklund at 2pi.dk>> wrote: >>>>>> >>>>>> >>>>>>> On Apr 21, 2015, at 05:39, Jonas Paulsson <jonas.paulsson at ericsson.com <mailto:jonas.paulsson at ericsson.com>> wrote: >>>>>>> >>>>>>> Could it then be that the RegisterCoalescer should split live ranges when LIS->shrinkToUses() return true? Why does it not do that, when the verifier demands this? >>>>>> I think it should. That's an oversight. >>>>> Yep, this is likely the problem. >>>>> >>>>> Jonas, do you think you can investigate a fix, or do you want me to look at it? >>>>> >>>>> Cheers, >>>>> -Quentin >>>> >>> >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu <http://llvm.cs.uiuc.edu/> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev <http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu <http://llvm.cs.uiuc.edu/> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev <http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev> > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150506/d5d26920/attachment.html>