Good point. But I suggest to do that by two steps. First, remove TargetLayout and rename DefaultLayout to TargetLayout. Second, merge TargetLayout and Layout. The first step is easy, the second step generates large diff, requires reviewing etc. On Fri, Apr 3, 2015 at 10:40 PM, Rui Ueyama <ruiu at google.com> wrote:> I'm wondering if we even need TargetLayout. > > DefaultLayout is the only derived class of Layout. TargetLayout is the only > derived class of DefaultLayout. It looks like we can merge Layout, > DefaultLayout and TargetLayout into one. > > On Fri, Apr 3, 2015 at 12:36 PM, Simon Atanasyan <simon at atanasyan.com> > wrote: >> >> Hi Rui, Shankar, >> >> Do we really need empty TargetLayout class? No we have the following >> hierarchy: >> >> Layout <- DefaultLayout<> <- TargetLayout<> <- xxxTargetLayout<> >> >> I suggest to remove TargetLayout and rename DefaultLayout to TargetLayout. >> >> Thoughts?-- Simon Atanasyan
Sure. Sounds good. On Fri, Apr 3, 2015 at 1:29 PM, Simon Atanasyan <simon at atanasyan.com> wrote:> Good point. But I suggest to do that by two steps. First, remove > TargetLayout and rename DefaultLayout to TargetLayout. Second, merge > TargetLayout and Layout. The first step is easy, the second step > generates large diff, requires reviewing etc. > > On Fri, Apr 3, 2015 at 10:40 PM, Rui Ueyama <ruiu at google.com> wrote: > > I'm wondering if we even need TargetLayout. > > > > DefaultLayout is the only derived class of Layout. TargetLayout is the > only > > derived class of DefaultLayout. It looks like we can merge Layout, > > DefaultLayout and TargetLayout into one. > > > > On Fri, Apr 3, 2015 at 12:36 PM, Simon Atanasyan <simon at atanasyan.com> > > wrote: > >> > >> Hi Rui, Shankar, > >> > >> Do we really need empty TargetLayout class? No we have the following > >> hierarchy: > >> > >> Layout <- DefaultLayout<> <- TargetLayout<> <- xxxTargetLayout<> > >> > >> I suggest to remove TargetLayout and rename DefaultLayout to > TargetLayout. > >> > >> Thoughts? > > -- > Simon Atanasyan >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150403/630d4333/attachment.html>
Merging TargetLayout and Layout classes unexpectedly produced rather small diff. I committed the change at r234065. On Fri, Apr 3, 2015 at 11:30 PM, Rui Ueyama <ruiu at google.com> wrote:> Sure. Sounds good. > > On Fri, Apr 3, 2015 at 1:29 PM, Simon Atanasyan <simon at atanasyan.com> wrote: >> >> Good point. But I suggest to do that by two steps. First, remove >> TargetLayout and rename DefaultLayout to TargetLayout. Second, merge >> TargetLayout and Layout. The first step is easy, the second step >> generates large diff, requires reviewing etc. >> >> On Fri, Apr 3, 2015 at 10:40 PM, Rui Ueyama <ruiu at google.com> wrote: >> > I'm wondering if we even need TargetLayout. >> > >> > DefaultLayout is the only derived class of Layout. TargetLayout is the >> > only >> > derived class of DefaultLayout. It looks like we can merge Layout, >> > DefaultLayout and TargetLayout into one. >> > >> > On Fri, Apr 3, 2015 at 12:36 PM, Simon Atanasyan <simon at atanasyan.com> >> > wrote: >> >> >> >> Hi Rui, Shankar, >> >> >> >> Do we really need empty TargetLayout class? No we have the following >> >> hierarchy: >> >> >> >> Layout <- DefaultLayout<> <- TargetLayout<> <- xxxTargetLayout<> >> >> >> >> I suggest to remove TargetLayout and rename DefaultLayout to >> >> TargetLayout. >> >> >> >> Thoughts? >> >> -- >> Simon Atanasyan > >-- Simon Atanasyan