Sedat Dilek
2015-Feb-17 11:42 UTC
[LLVMdev] [PATCH 2/2 v3] add visibility hidden to tls entry points
On Tue, Feb 17, 2015 at 12:38 PM, Marc Dietrich <marvin24 at gmx.de> wrote:> Am Dienstag, 17. Februar 2015, 11:58:06 schrieb Sedat Dilek: >> On Tue, Feb 17, 2015 at 10:40 AM, Marc Dietrich <marvin24 at gmx.de> wrote: >> > Avoid redefined symbol errors in clang. Based on a suggestion from >> > Rafael Ávila de Espíndola <rafael.espindola at gmail.com> in >> > http://llvm.org/bugs/show_bug.cgi?id=19778. >> > >> > Signed-off-by: Marc Dietrich <marvin24 at gmx.de> >> > --- >> > v2: - no change >> > v3: - include util directory in Makefile.am in order to avoid relative >> > >> > include paths, >> > >> > - make tls entry points array const >> >> I adapted this patch as v4 to fit mesa v10.4.4, but it fails (see >> log-file in attached tarball). > > the configure output says that visibility is not supported by your clang. > Interestingly, it is supported here (also clang 3.6 from yesterday). What does > config.log say about it? >Unfortunately, I have killed the build-dir and trying the patch from FreeBSD. I will rebuild and send you my config.log. Attached is my build-script for my llvm-toolchain. - Sedat - -------------- next part -------------- A non-text attachment was scrubbed... Name: build_llvm-toolchain.sh Type: application/x-sh Size: 1355 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150217/cb4858ac/attachment.sh>
Marc Dietrich
2015-Feb-17 11:47 UTC
[LLVMdev] [PATCH 2/2 v3] add visibility hidden to tls entry points
Am Dienstag, 17. Februar 2015, 12:42:00 schrieb Sedat Dilek:> On Tue, Feb 17, 2015 at 12:38 PM, Marc Dietrich <marvin24 at gmx.de> wrote: > > Am Dienstag, 17. Februar 2015, 11:58:06 schrieb Sedat Dilek: > >> On Tue, Feb 17, 2015 at 10:40 AM, Marc Dietrich <marvin24 at gmx.de> wrote: > >> > Avoid redefined symbol errors in clang. Based on a suggestion from > >> > Rafael Ávila de Espíndola <rafael.espindola at gmail.com> in > >> > http://llvm.org/bugs/show_bug.cgi?id=19778. > >> > > >> > Signed-off-by: Marc Dietrich <marvin24 at gmx.de> > >> > --- > >> > v2: - no change > >> > v3: - include util directory in Makefile.am in order to avoid relative > >> > > >> > include paths, > >> > > >> > - make tls entry points array const > >> > >> I adapted this patch as v4 to fit mesa v10.4.4, but it fails (see > >> log-file in attached tarball). > > > > the configure output says that visibility is not supported by your clang. > > Interestingly, it is supported here (also clang 3.6 from yesterday). What > > does config.log say about it? > > Unfortunately, I have killed the build-dir and trying the patch from > FreeBSD. I will rebuild and send you my config.log. > > Attached is my build-script for my llvm-toolchain.mmh, no compiler-rt? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: This is a digitally signed message part. URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150217/7b48b7f2/attachment.sig>
Sedat Dilek
2015-Feb-17 11:53 UTC
[LLVMdev] [PATCH 2/2 v3] add visibility hidden to tls entry points
On Tue, Feb 17, 2015 at 12:47 PM, Marc Dietrich <marvin24 at gmx.de> wrote:> Am Dienstag, 17. Februar 2015, 12:42:00 schrieb Sedat Dilek: >> On Tue, Feb 17, 2015 at 12:38 PM, Marc Dietrich <marvin24 at gmx.de> wrote: >> > Am Dienstag, 17. Februar 2015, 11:58:06 schrieb Sedat Dilek: >> >> On Tue, Feb 17, 2015 at 10:40 AM, Marc Dietrich <marvin24 at gmx.de> wrote: >> >> > Avoid redefined symbol errors in clang. Based on a suggestion from >> >> > Rafael Ávila de Espíndola <rafael.espindola at gmail.com> in >> >> > http://llvm.org/bugs/show_bug.cgi?id=19778. >> >> > >> >> > Signed-off-by: Marc Dietrich <marvin24 at gmx.de> >> >> > --- >> >> > v2: - no change >> >> > v3: - include util directory in Makefile.am in order to avoid relative >> >> > >> >> > include paths, >> >> > >> >> > - make tls entry points array const >> >> >> >> I adapted this patch as v4 to fit mesa v10.4.4, but it fails (see >> >> log-file in attached tarball). >> > >> > the configure output says that visibility is not supported by your clang. >> > Interestingly, it is supported here (also clang 3.6 from yesterday). What >> > does config.log say about it? >> >> Unfortunately, I have killed the build-dir and trying the patch from >> FreeBSD. I will rebuild and send you my config.log. >> >> Attached is my build-script for my llvm-toolchain. > > mmh, no compiler-rt?NO. Can you explain why do I need it? - Sedat -