Hi Hans, I have attached a unit test which demonstrates a hang/infinite loop with the opt built with release_36 sources. The fixes are already pushed to "master" branch. The revisions r226588 and r226616 should be pushed to release_36 to fix the unit test. --Sumanth G -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150212/3401da38/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: test.ll Type: application/octet-stream Size: 5497 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150212/3401da38/attachment.obj>
Adrian, are these safe to merge? They seem to apply cleanly on the branch. On Thu, Feb 12, 2015 at 2:51 PM, Sumanth Gundapaneni <sgundapa at codeaurora.org> wrote:> Hi Hans, > > I have attached a unit test which demonstrates a > hang/infinite loop with the opt built with release_36 sources. > > The fixes are already pushed to “master” branch. The revisions r226588 and > r226616 should be pushed to release_36 to fix the unit test. > > > > --Sumanth G
Yes both should be safe and allow the debug info verifier to not get stuck in an infinite loops when it comes across malformed (=outdated) metadata. -- adrian> On Feb 12, 2015, at 3:26 PM, Hans Wennborg <hans at chromium.org> wrote: > > Adrian, are these safe to merge? > > They seem to apply cleanly on the branch. > > On Thu, Feb 12, 2015 at 2:51 PM, Sumanth Gundapaneni > <sgundapa at codeaurora.org> wrote: >> Hi Hans, >> >> I have attached a unit test which demonstrates a >> hang/infinite loop with the opt built with release_36 sources. >> >> The fixes are already pushed to “master” branch. The revisions r226588 and >> r226616 should be pushed to release_36 to fix the unit test. >> >> >> >> --Sumanth G