Eric Fiselier
2015-Feb-06 15:07 UTC
[LLVMdev] [cfe-dev] [3.6 Release] Release Candidate 2 available
Hi all, I would really like to get a patch into 3.6 for libc++. The patch renames template parameters with the names '_A' and '_V' to longer names. '_A' is frequently defined in ctypes.h and that could cause libc++ to not compile. I'm fairly sure the code was added between 3.5 and 3.6 so that would make this a regression. The patch can be found here: http://reviews.llvm.org/rL228353. I've attached a patch that just modifies the headers and leaves the tests alone (the test changes may not merge nicely). Is this going to be possible? /Eric On Thu, Feb 5, 2015 at 2:32 PM, Hans Wennborg <hans at chromium.org> wrote:> On Thu, Feb 5, 2015 at 11:10 AM, Sylvestre Ledru <sylvestre at debian.org> wrote: >> On 05/02/2015 18:34, Hans Wennborg wrote: >>> On Tue, Feb 3, 2015 at 11:47 AM, Hans Wennborg <hans at chromium.org> wrote: >>>> Hello all, >>>> >>>> Source and binaries for LLVM 3.6.0-rc2 are now available at >>>> http://llvm.org/pre-releases/3.6.0/ >>>> >>>> Please try them out, run tests, build your favourite projects, and >>>> *file bugs* about anything that doesn't work or needs to be fixed for >>>> the release. >>>> >>>> Release blockers are tracked by http://llvm.org/PR22374 >>> >> FYI, it builds fine now under HURD & Kfreebsd and the rest of the Debian >> archs. > > Cool! > >> I landed this patch for HURD: >> http://reviews.llvm.org/rL228331 >> >> And waiting for review about lldb on kfreebsd: >> http://reviews.llvm.org/D7441 >> >> I don't mind if you are not going to take them for 3.6. I am applying >> both patches >> on top of the package and I don't think many people care... > > I'm happy to merge if it's non-disruptive and fixes stuff. I've pinged > Hal about the first one; let me know how the second one goes. > > Thanks, > Hans > _______________________________________________ > cfe-dev mailing list > cfe-dev at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev-------------- next part -------------- A non-text attachment was scrubbed... Name: name.patch Type: text/x-patch Size: 255484 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150206/d176c12e/attachment.bin>
Hans Wennborg
2015-Feb-06 16:44 UTC
[LLVMdev] [cfe-dev] [3.6 Release] Release Candidate 2 available
Sounds reasonable to me if Marshall is okay with it. Thanks, Hans On Fri, Feb 6, 2015 at 7:07 AM, Eric Fiselier <eric at efcs.ca> wrote:> Hi all, > > I would really like to get a patch into 3.6 for libc++. The patch > renames template parameters with the names '_A' and '_V' to longer > names. '_A' is frequently defined in ctypes.h and that could cause > libc++ to not compile. > I'm fairly sure the code was added between 3.5 and 3.6 so that would > make this a regression. > > The patch can be found here: http://reviews.llvm.org/rL228353. I've > attached a patch that just modifies the headers and leaves the tests > alone (the test changes may not merge nicely). > > Is this going to be possible? > > /Eric > > On Thu, Feb 5, 2015 at 2:32 PM, Hans Wennborg <hans at chromium.org> wrote: >> On Thu, Feb 5, 2015 at 11:10 AM, Sylvestre Ledru <sylvestre at debian.org> wrote: >>> On 05/02/2015 18:34, Hans Wennborg wrote: >>>> On Tue, Feb 3, 2015 at 11:47 AM, Hans Wennborg <hans at chromium.org> wrote: >>>>> Hello all, >>>>> >>>>> Source and binaries for LLVM 3.6.0-rc2 are now available at >>>>> http://llvm.org/pre-releases/3.6.0/ >>>>> >>>>> Please try them out, run tests, build your favourite projects, and >>>>> *file bugs* about anything that doesn't work or needs to be fixed for >>>>> the release. >>>>> >>>>> Release blockers are tracked by http://llvm.org/PR22374 >>>> >>> FYI, it builds fine now under HURD & Kfreebsd and the rest of the Debian >>> archs. >> >> Cool! >> >>> I landed this patch for HURD: >>> http://reviews.llvm.org/rL228331 >>> >>> And waiting for review about lldb on kfreebsd: >>> http://reviews.llvm.org/D7441 >>> >>> I don't mind if you are not going to take them for 3.6. I am applying >>> both patches >>> on top of the package and I don't think many people care... >> >> I'm happy to merge if it's non-disruptive and fixes stuff. I've pinged >> Hal about the first one; let me know how the second one goes. >> >> Thanks, >> Hans >> _______________________________________________ >> cfe-dev mailing list >> cfe-dev at cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
Dimitry Andric
2015-Feb-07 16:39 UTC
[LLVMdev] [cfe-dev] [3.6 Release] Release Candidate 2 available
Yes, please. -Dimitry> On 06 Feb 2015, at 16:07, Eric Fiselier <eric at efcs.ca> wrote: > > Hi all, > > I would really like to get a patch into 3.6 for libc++. The patch > renames template parameters with the names '_A' and '_V' to longer > names. '_A' is frequently defined in ctypes.h and that could cause > libc++ to not compile. > I'm fairly sure the code was added between 3.5 and 3.6 so that would > make this a regression. > > The patch can be found here: http://reviews.llvm.org/rL228353. I've > attached a patch that just modifies the headers and leaves the tests > alone (the test changes may not merge nicely). > > Is this going to be possible? > > /Eric > > On Thu, Feb 5, 2015 at 2:32 PM, Hans Wennborg <hans at chromium.org> wrote: >> On Thu, Feb 5, 2015 at 11:10 AM, Sylvestre Ledru <sylvestre at debian.org> wrote: >>> On 05/02/2015 18:34, Hans Wennborg wrote: >>>> On Tue, Feb 3, 2015 at 11:47 AM, Hans Wennborg <hans at chromium.org> wrote: >>>>> Hello all, >>>>> >>>>> Source and binaries for LLVM 3.6.0-rc2 are now available at >>>>> http://llvm.org/pre-releases/3.6.0/ >>>>> >>>>> Please try them out, run tests, build your favourite projects, and >>>>> *file bugs* about anything that doesn't work or needs to be fixed for >>>>> the release. >>>>> >>>>> Release blockers are tracked by http://llvm.org/PR22374 >>>> >>> FYI, it builds fine now under HURD & Kfreebsd and the rest of the Debian >>> archs. >> >> Cool! >> >>> I landed this patch for HURD: >>> http://reviews.llvm.org/rL228331 >>> >>> And waiting for review about lldb on kfreebsd: >>> http://reviews.llvm.org/D7441 >>> >>> I don't mind if you are not going to take them for 3.6. I am applying >>> both patches >>> on top of the package and I don't think many people care... >> >> I'm happy to merge if it's non-disruptive and fixes stuff. I've pinged >> Hal about the first one; let me know how the second one goes. >> >> Thanks, >> Hans >> _______________________________________________ >> cfe-dev mailing list >> cfe-dev at cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev > <name.patch>_______________________________________________ > cfe-dev mailing list > cfe-dev at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev-------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 194 bytes Desc: Message signed with OpenPGP using GPGMail URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150207/1af7074a/attachment.sig>
Hans Wennborg
2015-Feb-07 19:14 UTC
[LLVMdev] [cfe-dev] [3.6 Release] Release Candidate 2 available
Marshall, you're the owner here. Is this OK to merge? On Sat, Feb 7, 2015 at 8:39 AM, Dimitry Andric <dimitry at andric.com> wrote:> Yes, please. > > -Dimitry > >> On 06 Feb 2015, at 16:07, Eric Fiselier <eric at efcs.ca> wrote: >> >> Hi all, >> >> I would really like to get a patch into 3.6 for libc++. The patch >> renames template parameters with the names '_A' and '_V' to longer >> names. '_A' is frequently defined in ctypes.h and that could cause >> libc++ to not compile. >> I'm fairly sure the code was added between 3.5 and 3.6 so that would >> make this a regression. >> >> The patch can be found here: http://reviews.llvm.org/rL228353. I've >> attached a patch that just modifies the headers and leaves the tests >> alone (the test changes may not merge nicely). >> >> Is this going to be possible? >> >> /Eric >> >> On Thu, Feb 5, 2015 at 2:32 PM, Hans Wennborg <hans at chromium.org> wrote: >>> On Thu, Feb 5, 2015 at 11:10 AM, Sylvestre Ledru <sylvestre at debian.org> wrote: >>>> On 05/02/2015 18:34, Hans Wennborg wrote: >>>>> On Tue, Feb 3, 2015 at 11:47 AM, Hans Wennborg <hans at chromium.org> wrote: >>>>>> Hello all, >>>>>> >>>>>> Source and binaries for LLVM 3.6.0-rc2 are now available at >>>>>> http://llvm.org/pre-releases/3.6.0/ >>>>>> >>>>>> Please try them out, run tests, build your favourite projects, and >>>>>> *file bugs* about anything that doesn't work or needs to be fixed for >>>>>> the release. >>>>>> >>>>>> Release blockers are tracked by http://llvm.org/PR22374 >>>>> >>>> FYI, it builds fine now under HURD & Kfreebsd and the rest of the Debian >>>> archs. >>> >>> Cool! >>> >>>> I landed this patch for HURD: >>>> http://reviews.llvm.org/rL228331 >>>> >>>> And waiting for review about lldb on kfreebsd: >>>> http://reviews.llvm.org/D7441 >>>> >>>> I don't mind if you are not going to take them for 3.6. I am applying >>>> both patches >>>> on top of the package and I don't think many people care... >>> >>> I'm happy to merge if it's non-disruptive and fixes stuff. I've pinged >>> Hal about the first one; let me know how the second one goes. >>> >>> Thanks, >>> Hans >>> _______________________________________________ >>> cfe-dev mailing list >>> cfe-dev at cs.uiuc.edu >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev >> <name.patch>_______________________________________________ >> cfe-dev mailing list >> cfe-dev at cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev >
Maybe Matching Threads
- [LLVMdev] [cfe-dev] [3.6 Release] Release Candidate 2 available
- [LLVMdev] [3.6 Release] Release Candidate 2 available
- [LLVMdev] [3.6 Release] Release Candidate 2 available
- [LLVMdev] [3.6 Release] RC1 has been tagged, Testing Phase I begins
- [LLVMdev] [3.6 Release] RC2 has been tagged, Testing Phase II begins