Hi, I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 branch of the test-suite. If you have any questions, let me know. -Tom
On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <tom at stellard.net> wrote:> Hi, > > I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 > branch of the test-suite. If you have any questions, let me know.I've uploaded the Windows installer to the sftp with sha1: b56681a457954916ac9c8f0d36426cde0a21ee1d LLVM-3.5.1-rc2-win32.exe Build worked fine this time. The only failing lit test is Modules/compiler_builtins.m, which I guess is PR20995. That's probably not cause for concern, but maybe we should remove the test from the branch for those who build from source? CC'ing Yaron who has looked at the PR some. - Hans
I've uploaded clang+llvm-3.5.1-rc2-mips-linux-gnu.tar.xz and clang+llvm-3.5.1-rc2-mipsel-linux-gnu.tar.xz. The latter fails prune.m in 'make check-all' as it did last time but this is because the 'touch -a' command isn't actually changing the access timestamp. I've started the test-suite for both of them. ________________________________________ From: llvmdev-bounces at cs.uiuc.edu [llvmdev-bounces at cs.uiuc.edu] on behalf of Hans Wennborg [hans at chromium.org] Sent: 19 December 2014 23:50 To: Tom Stellard Cc: Ben Pope; Nikola Smiljanic; llvmdev Subject: Re: [LLVMdev] 3.5.1 Testing Phase II Begins On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <tom at stellard.net> wrote:> Hi, > > I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 > branch of the test-suite. If you have any questions, let me know.I've uploaded the Windows installer to the sftp with sha1: b56681a457954916ac9c8f0d36426cde0a21ee1d LLVM-3.5.1-rc2-win32.exe Build worked fine this time. The only failing lit test is Modules/compiler_builtins.m, which I guess is PR20995. That's probably not cause for concern, but maybe we should remove the test from the branch for those who build from source? CC'ing Yaron who has looked at the PR some. - Hans _______________________________________________ LLVM Developers mailing list LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
On Saturday, December 20, 2014 06:35 AM, Tom Stellard wrote:> Hi, > > I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 > branch of the test-suite. If you have any questions, let me know. > > -Tomuploads/clang+llvm-3.5.1-rc2-x86_64-linux-gnu-ubuntu-14.04.tar.xz The tests all pass, but there seems to be a significant runtime performance regression in MultiSource/Benchmarks/nbench/nbench since rc1 (it's a long running test that's about 50% slower). Ben -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141222/4006379b/attachment.html>
Uploaded Fedora and OpenSUSE last night, all looks good. On Mon, Dec 22, 2014 at 2:47 PM, Ben Pope <benpope81 at gmail.com> wrote:> On Saturday, December 20, 2014 06:35 AM, Tom Stellard wrote: > > Hi, > > I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 > branch of the test-suite. If you have any questions, let me know. > > -Tom > > > uploads/clang+llvm-3.5.1-rc2-x86_64-linux-gnu-ubuntu-14.04.tar.xz > > The tests all pass, but there seems to be a significant runtime > performance regression in MultiSource/Benchmarks/nbench/nbench since rc1 > (it's a long running test that's about 50% slower). > > Ben >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141222/811d3438/attachment.html>
On 19/12/2014 23:35, Tom Stellard wrote:> Hi, > > I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 > branch of the test-suite. If you have any questions, let me know. > >Nothing special for Debian. 3.5.1 rc2 builds fine on (almost) all archs. https://buildd.debian.org/status/package.php?p=llvm-toolchain-3.5&suite=experimental Cheers, Sylvestre
On Fri, Dec 19, 2014 at 03:50:30PM -0800, Hans Wennborg wrote:> On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <tom at stellard.net> wrote: > > Hi, > > > > I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 > > branch of the test-suite. If you have any questions, let me know. > > I've uploaded the Windows installer to the sftp with sha1: > b56681a457954916ac9c8f0d36426cde0a21ee1d LLVM-3.5.1-rc2-win32.exe > > Build worked fine this time. The only failing lit test is > Modules/compiler_builtins.m, which I guess is PR20995. That's probably > not cause for concern, but maybe we should remove the test from the > branch for those who build from source? CC'ing Yaron who has looked at > the PR some. >Did this test also fail in 3.5.0 and/or 3.5.1-rc1 ? -Tom> - Hans
Hey Tom, David has pointed out to me that we have some *really* bad bugs in instcombine in 3.5 that are starting to seriously impact users. http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM itself doesn't trip over this bug, and I suspect an innocent change to LLVM could result in that. Do you think it's possible to spin a rc3 with a couple more patches to fix this? I think David has already curated the patches and would be willing to ensure they merge cleanly. I'm going to help review them as OK. My hope is that this won't require a huge delay in 3.5.1, but what do you think? -Chandler On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <tom at stellard.net> wrote:> Hi, > > I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 > branch of the test-suite. If you have any questions, let me know. > > -Tom > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141229/47093200/attachment.html>
The most relevant of these is r222856 which reverted a set of broken optimizations in r210006. I'd be happy with just including r222856. Optionally, we could take r222868 and r222871 which correctly restore the optimization. On Mon, Dec 29, 2014 at 2:39 PM, Chandler Carruth <chandlerc at google.com> wrote:> Hey Tom, > > David has pointed out to me that we have some *really* bad bugs in > instcombine in 3.5 that are starting to seriously impact users. > http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM > itself doesn't trip over this bug, and I suspect an innocent change to LLVM > could result in that. > > Do you think it's possible to spin a rc3 with a couple more patches to fix > this? I think David has already curated the patches and would be willing to > ensure they merge cleanly. I'm going to help review them as OK. My hope is > that this won't require a huge delay in 3.5.1, but what do you think? > > -Chandler > > On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <tom at stellard.net> wrote: > >> Hi, >> >> I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 >> branch of the test-suite. If you have any questions, let me know. >> >> -Tom >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141229/c781cf36/attachment.html>
On Mon, Dec 29, 2014 at 11:39:42AM -0800, Chandler Carruth wrote:> Hey Tom, > > David has pointed out to me that we have some *really* bad bugs in > instcombine in 3.5 that are starting to seriously impact users. > http://llvm.org/PR22050 is a great example. I'm actually surprised LLVM > itself doesn't trip over this bug, and I suspect an innocent change to LLVM > could result in that. > > Do you think it's possible to spin a rc3 with a couple more patches to fix > this? I think David has already curated the patches and would be willing to > ensure they merge cleanly. I'm going to help review them as OK. My hope is > that this won't require a huge delay in 3.5.1, but what do you think? >The release is already somewhat delayed due to the holidays. I was hoping -rc2 would be the last one, but there may be other issues anyway. Do you have the list of patches that David wants to merge? I will review them and then he can merge them into the 3.5 branch so they are ready in case there is an -rc3. -Tom> -Chandler > > On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <tom at stellard.net> wrote: > > > Hi, > > > > I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 > > branch of the test-suite. If you have any questions, let me know. > > > > -Tom > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >