Christophe Lyon
2014-Dec-16 20:29 UTC
[LLVMdev] [Compiler-rt] -march=aarch64 flag in gcc/clang
On 16 December 2014 at 21:12, Gundapaneni, Sumanth <sgundapa at quicinc.com> wrote:> The point here is, if you are not building for Android. > You will hit this patch with cmake configuration -DCOMPILER_RT_TEST_TRIPLE=aarch64-linux-gnu > > + elseif("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "aarch64") > + test_target_arch(aarch64 "-march=aarch64") > > I don't see "-march=aarch64" is a valid flag on either LLVM or GCC. > Should we replace this with a flag which is valid for only aarch64 and works for both LLVM and GCC ?I think it should be -march=armv8-a> > If the compiler-rt build works for others, I would like to see their cmake recipe ? > > --Sumanth G > -----Original Message----- > From: Tim Northover [mailto:t.p.northover at gmail.com] > Sent: Wednesday, December 10, 2014 8:02 AM > To: Christophe Lyon > Cc: Renato Golin; Gundapaneni, Sumanth; llvmdev at cs.uiuc.edu; Kostya Serebryany > Subject: Re: [Compiler-rt] -march=aarch64 flag in gcc/clang > >> Not sure what r181130 is supposed to do, though, since it introduces a >> buggy option. > > I didn't even have compiler-rt checked out when I was doing that; I was just trying to get the base check-all working. As I recall that option filtered through to some llvm-lit config files. Though it might have been a .inc header. > > Cheers. > > Tim.
Gundapaneni, Sumanth
2014-Dec-17 23:02 UTC
[LLVMdev] [Compiler-rt] -march=aarch64 flag in gcc/clang
Renato, I think there was a typo in the patch - test_target_arch(aarch64 "-march=aarch64") + test_target_arch(aarch32 "-march=armv8-a") It has to be aarch64 instead of aarch32 in the new patch. --Sumanth G -----Original Message----- From: Renato Golin [mailto:renato.golin at linaro.org] Sent: Tuesday, December 16, 2014 12:33 PM To: Christophe Lyon Cc: Gundapaneni, Sumanth; Tim Northover; llvmdev at cs.uiuc.edu; Kostya Serebryany Subject: Re: [Compiler-rt] -march=aarch64 flag in gcc/clang On 16 December 2014 at 20:29, Christophe Lyon <christophe.lyon at linaro.org> wrote:>> I don't see "-march=aarch64" is a valid flag on either LLVM or GCC. >> Should we replace this with a flag which is valid for only aarch64 and works for both LLVM and GCC ? > > I think it should be -march=armv8-aSorry folks, that was totally my fault and I was too busy to realise it. I have just changed it to "armv8-a" on r224362. I'm building it now and it's working. cheers, --renato
James Molloy
2014-Dec-18 08:07 UTC
[LLVMdev] [Compiler-rt] -march=aarch64 flag in gcc/clang
Hi Renato, Are you sure? Armv8-a is aarch32, not aarch64. Something smells fishy there. Cheers, James On Thu, 18 Dec 2014 at 08:03, Renato Golin <renato.golin at linaro.org> wrote:> On 16 December 2014 at 20:29, Christophe Lyon > <christophe.lyon at linaro.org> wrote: > >> I don't see "-march=aarch64" is a valid flag on either LLVM or GCC. > >> Should we replace this with a flag which is valid for only aarch64 and > works for both LLVM and GCC ? > > > > I think it should be -march=armv8-a > > Sorry folks, that was totally my fault and I was too busy to realise > it. I have just changed it to "armv8-a" on r224362. I'm building it > now and it's working. > > cheers, > --renato > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141218/92bf2028/attachment.html>