Tom Stellard
2014-Dec-05 21:33 UTC
[LLVMdev] Vectorize Patches for 3.5.1 (was Re: Proposed patches for Clang 3.5.1)
On Wed, Dec 03, 2014 at 11:51:07AM -0800, Michael Zolotukhin wrote:> Hi Tom, > > I also have several patches that might be useful in 3.5.1. They all are stability fixes: > > r221009: Correctly update dom-tree after loop vectorizer. > r222451: Fix a trip-count overflow issue in LoopUnroll. > r223170 and r223171: PR21302.Vectorize only bottom-tested loops. >Hi Arnold, Nadav, and Hal Are these patches OK for the 3.5 branch. Here are the links: http://llvm.org/viewvc/llvm-project?view=revision&revision=221009 http://llvm.org/viewvc/llvm-project?view=revision&revision=222451 http://llvm.org/viewvc/llvm-project?view=revision&revision=223170 http://llvm.org/viewvc/llvm-project?view=revision&revision=223171 -Tom> Are these patches look ok for 3.5.1? > > Thanks, > Michael > > > On Dec 2, 2014, at 8:40 AM, Tom Stellard <tom at stellard.net> wrote: > > > > On Sat, Nov 29, 2014 at 08:34:34PM +0100, Dimitry Andric wrote: > >> On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote: > >>> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote: > >> ... > >>>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :) > >> ... > >>> Can you cc the appropriate code owners to get their approval. It might > >>> help to send a separate email per code owner. > >> > >> Hi Renato, > >> > >> Can you please approve the following revisions for backporting to 3.5.1: > >> > >> r216989: Only emit movw on ARMv6T2+ > >> r216990: Missing test from r216989 > >> > > > > These both LGTM, go ahead and merge into the 3.5 branch. > > > > -Tom > > > >> -Dimitry > >> > > > > > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu <http://llvm.cs.uiuc.edu/> > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev <http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev>
Arnold Schwaighofer
2014-Dec-05 21:36 UTC
[LLVMdev] Vectorize Patches for 3.5.1 (was Re: Proposed patches for Clang 3.5.1)
LGTM.> On Dec 5, 2014, at 1:33 PM, Tom Stellard <tom at stellard.net> wrote: > > On Wed, Dec 03, 2014 at 11:51:07AM -0800, Michael Zolotukhin wrote: >> Hi Tom, >> >> I also have several patches that might be useful in 3.5.1. They all are stability fixes: >> >> r221009: Correctly update dom-tree after loop vectorizer. >> r222451: Fix a trip-count overflow issue in LoopUnroll. >> r223170 and r223171: PR21302.Vectorize only bottom-tested loops. >> > > Hi Arnold, Nadav, and Hal > > Are these patches OK for the 3.5 branch. Here are the links: > > http://llvm.org/viewvc/llvm-project?view=revision&revision=221009 > http://llvm.org/viewvc/llvm-project?view=revision&revision=222451 > http://llvm.org/viewvc/llvm-project?view=revision&revision=223170 > http://llvm.org/viewvc/llvm-project?view=revision&revision=223171 > > -Tom > >> Are these patches look ok for 3.5.1? >> >> Thanks, >> Michael >> >>> On Dec 2, 2014, at 8:40 AM, Tom Stellard <tom at stellard.net> wrote: >>> >>> On Sat, Nov 29, 2014 at 08:34:34PM +0100, Dimitry Andric wrote: >>>> On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote: >>>>> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote: >>>> ... >>>>>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :) >>>> ... >>>>> Can you cc the appropriate code owners to get their approval. It might >>>>> help to send a separate email per code owner. >>>> >>>> Hi Renato, >>>> >>>> Can you please approve the following revisions for backporting to 3.5.1: >>>> >>>> r216989: Only emit movw on ARMv6T2+ >>>> r216990: Missing test from r216989 >>>> >>> >>> These both LGTM, go ahead and merge into the 3.5 branch. >>> >>> -Tom >>> >>>> -Dimitry >>>> >>> >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu <http://llvm.cs.uiuc.edu/> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev <http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev>
Tom Stellard
2014-Dec-05 21:40 UTC
[LLVMdev] Vectorize Patches for 3.5.1 (was Re: Proposed patches for Clang 3.5.1)
Michael, LGTM, go ahead and merge them to the 3.5 branch. -Tom On Fri, Dec 05, 2014 at 01:36:48PM -0800, Arnold Schwaighofer wrote:> LGTM. > > > > On Dec 5, 2014, at 1:33 PM, Tom Stellard <tom at stellard.net> wrote: > > > > On Wed, Dec 03, 2014 at 11:51:07AM -0800, Michael Zolotukhin wrote: > >> Hi Tom, > >> > >> I also have several patches that might be useful in 3.5.1. They all are stability fixes: > >> > >> r221009: Correctly update dom-tree after loop vectorizer. > >> r222451: Fix a trip-count overflow issue in LoopUnroll. > >> r223170 and r223171: PR21302.Vectorize only bottom-tested loops. > >> > > > > Hi Arnold, Nadav, and Hal > > > > Are these patches OK for the 3.5 branch. Here are the links: > > > > http://llvm.org/viewvc/llvm-project?view=revision&revision=221009 > > http://llvm.org/viewvc/llvm-project?view=revision&revision=222451 > > http://llvm.org/viewvc/llvm-project?view=revision&revision=223170 > > http://llvm.org/viewvc/llvm-project?view=revision&revision=223171 > > > > -Tom > > > >> Are these patches look ok for 3.5.1? > >> > >> Thanks, > >> Michael > >> > >>> On Dec 2, 2014, at 8:40 AM, Tom Stellard <tom at stellard.net> wrote: > >>> > >>> On Sat, Nov 29, 2014 at 08:34:34PM +0100, Dimitry Andric wrote: > >>>> On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote: > >>>>> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote: > >>>> ... > >>>>>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :) > >>>> ... > >>>>> Can you cc the appropriate code owners to get their approval. It might > >>>>> help to send a separate email per code owner. > >>>> > >>>> Hi Renato, > >>>> > >>>> Can you please approve the following revisions for backporting to 3.5.1: > >>>> > >>>> r216989: Only emit movw on ARMv6T2+ > >>>> r216990: Missing test from r216989 > >>>> > >>> > >>> These both LGTM, go ahead and merge into the 3.5 branch. > >>> > >>> -Tom > >>> > >>>> -Dimitry > >>>> > >>> > >>> > >>> _______________________________________________ > >>> LLVM Developers mailing list > >>> LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu <http://llvm.cs.uiuc.edu/> > >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev <http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev> >